docs(changelog): add agent-clip-demo entry #46
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -16,6 +16,7 @@ See `README.md` for setup. Run the repo's lint / typecheck / test before opening | |||||
| ## Security | ||||||
|
|
||||||
| Report vulnerabilities via the [Security Policy](https://github.com/wave-av/.github/blob/main/SECURITY.md) (security@wave.online) — never in a public issue. | ||||||
| <<<<<<< Updated upstream | ||||||
|
There was a problem hiding this comment. 🔍 Unresolved conflict corrupts agent guidance Conflict markers preserve two 
Was this helpful? React with 👍 or 👎 to provide feedback. There was a problem hiding this comment. Suggestion: Unresolved merge-conflict markers are committed, so agent instructions include conflict metadata and parsers or validation checks can fail. [possible bug] Assessment: 🟠
Prompt for AI Agent 🤖This is a comment left during a code review.
**Path:** AGENTS.md
**Line:** 19:19
**Comment:**
*Possible Bug: Unresolved merge-conflict markers are committed, so agent instructions include conflict metadata and parsers or validation checks can fail.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fixThere was a problem hiding this comment. P2: AGENTS.md still contains an unresolved merge conflict: Prompt for AI agentsThere was a problem hiding this comment. 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win Resolve the unresolved merge conflicts in both documentation files before merge.
The issue causes documentation ambiguity, not a major functional failure. Classify it as minor. 🤖 Prompt for AI Agents |
||||||
|
|
||||||
| # Platform Context | ||||||
|
|
||||||
|
|
@@ -57,3 +58,18 @@ index: | |||||
| - family: permissions-contract | ||||||
| path: PERMISSIONS.md | ||||||
| ``` | ||||||
| ||||||| Stash base | ||||||
| ======= | ||||||
|
|
||||||
| # Platform Context | ||||||
|
|
||||||
| You are working inside the WAVE platform (wave-av org, 157 repos). Before acting: | ||||||
|
|
||||||
| 1. **The registry is the SSOT.** Query it via `@wave-av/registry-sdk` or the REST API at `https://goqtrxgdmaqojmixradj.supabase.co/rest/v1/<table>`. Tables: models, tools, vendors, products (25+ with data planes), deliverables, tests, prose, usage_logs. | ||||||
| 2. **Five physics laws gate everything** in CI: gauge-invariance (no raw slug), frame-independence (scores inherited), conservation-of-declaration (four renderings), entropy-monotonicity (nothing unregistered), token-budget-conservation. | ||||||
| 3. **The full fleet map** lives at `governance/plans/session-deliverable-registry/PLATFORM-MAP.md` in claude-workstation (157 repos by kind: core/spoke/ssot/tool/sdk). | ||||||
| 4. **The 24-axis model taxonomy** lives at `wave-foundation/frameworks/model-routing/champions.json` (calibrated_at 2026-08-24). | ||||||
| 5. **The inference pool** runs on our rigs at `http://100.92.89.55:8800/v1` (internal, $0). Frontier fallback via openrouter/anthropic. The rail field on models tracks internal vs customer. | ||||||
|
There was a problem hiding this comment. 🟥 Internal fleet address exposed publicly The added context publishes internal Tailscale address
Was this helpful? React with 👍 or 👎 to provide feedback. There was a problem hiding this comment. P1: Resolving this conflict in favor of the Stashed-changes side would commit the real internal inference-pool address Prompt for AI agents
Suggested change
|
||||||
| 6. **The voice laws**: no em-dashes, every word earns its place, short words over long, active voice, receipt over adjective. Enforced by voice-gate.mjs. | ||||||
| 7. **The test-matrix**: every shipped artifact carries unit/integration/smoke/e2e/probe receipts in the tests table. No test, no ship. | ||||||
| >>>>>>> Stashed changes | ||||||
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -5,6 +5,7 @@ All notable changes to this project are documented here. The format is based on | |||||||||
| [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | ||||||||||
|
|
||||||||||
| ## [Unreleased] | ||||||||||
| <<<<<<< HEAD | ||||||||||
|
There was a problem hiding this comment. 🚨 Bug: Unresolved git conflict markers left in CHANGELOG.mdCHANGELOG.md still contains literal Merge both sides of the conflict under one Unreleased section and drop the markers: Was this helpful? React with 👍 / 👎 There was a problem hiding this comment. 🔍 Unresolved conflict corrupts release notes Merge delimiters wrap both
Was this helpful? React with 👍 or 👎 to provide feedback. There was a problem hiding this comment. Suggestion: Unresolved merge-conflict markers surround the Unreleased entries, so changelog parsers can emit conflict text or misclassify release notes. [possible bug] Assessment: 🟠
Prompt for AI Agent 🤖This is a comment left during a code review.
**Path:** CHANGELOG.md
**Line:** 8:8
**Comment:**
*Possible Bug: Unresolved merge-conflict markers surround the Unreleased entries, so changelog parsers can emit conflict text or misclassify release notes.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fixThere was a problem hiding this comment. P1: The commit leaves unresolved Git merge-conflict markers in CHANGELOG.md: Prompt for AI agents |
||||||||||
|
|
||||||||||
| ### Fixed | ||||||||||
|
|
||||||||||
|
|
@@ -31,3 +32,24 @@ All notable changes to this project are documented here. The format is based on | |||||||||
| Contributors on forks are affected: a maintainer's `/review` on a fork PR is | ||||||||||
| now declined with a warning rather than silently running. | ||||||||||
| (wave-av/wave-foundation-public#73) | ||||||||||
| ||||||| parent of 4ae7471 (docs(changelog): add agent-clip-demo entry) | ||||||||||
| ======= | ||||||||||
|
|
||||||||||
| ### Added | ||||||||||
|
|
||||||||||
| - **agent-clip-demo** — end-to-end agent-video demo: voice synthesis → clip | ||||||||||
|
There was a problem hiding this comment. 🔍 Release note breaks voice convention The new entry uses an em dash despite the repository rule banning them. Revise the separator before merge.
Was this helpful? React with 👍 or 👎 to provide feedback. |
||||||||||
| creation → signed video delivery, verified against the live production API. | ||||||||||
|
|
||||||||||
| Three commands (`demo.mjs synthesize | clip | all`) reproduce the keystone | ||||||||||
| pipeline: `POST /v1/voice {text}` returns real `audio/mpeg` MP3 narration; | ||||||||||
| `POST /v1/clips {source, in, out}` returns a `201` clipId + HMAC-signed | ||||||||||
| delivery URL; the delivery URL serves `200 video/mp4` from | ||||||||||
| `media.wave.online`. Includes a WAVE-branded showcase page (`index.html`) | ||||||||||
| and a pre-rendered sample video (WAVE narration over a Big Buck Bunny | ||||||||||
| source clip). | ||||||||||
|
Comment on lines
+40
to
+49
There was a problem hiding this comment. 🔍 Release notes advertise absent artifacts The entry promises
Was this helpful? React with 👍 or 👎 to provide feedback.
Comment on lines
+43
to
+49
There was a problem hiding this comment. Suggestion: The entry claims Assessment: 🟠
Prompt for AI Agent 🤖This is a comment left during a code review.
**Path:** CHANGELOG.md
**Line:** 43:49
**Comment:**
*Api Mismatch: The entry claims `demo.mjs`, `index.html`, and a pre-rendered video exist, but none of these artifacts are present in this checkout, making the documented demo unreproducible.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
Comment on lines
+47
to
+49
There was a problem hiding this comment. P2: Remove the Prompt for AI agents
Suggested change
|
||||||||||
|
|
||||||||||
| Verification receipts: source recording `f7acfa81-…` (BBB, .mp4, ready) | ||||||||||
| → clip create `201` → clip engine produced 46KB 5s 1280×720 H.264/AAC | ||||||||||
| → signed URL `200 video/mp4`. All against `api.wave.online` and | ||||||||||
| `media.wave.online`. | ||||||||||
| >>>>>>> 4ae7471 (docs(changelog): add agent-clip-demo entry) | ||||||||||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 Security: Unresolved conflict in AGENTS.md exposes internal inference host
AGENTS.md also contains unresolved conflict markers (lines 19, 61-63, 75) between an upstream placeholder inference URL and a local stashed version that hardcodes a concrete internal IP
http://100.92.89.55:8800/v1at line 72. If merged, this leaks an internal infrastructure address on the (presumably public) default branch. Resolve the conflict, remove the markers, and replace the concrete IP with the placeholder<fleet-internal-address>(or otherwise avoid committing real internal endpoints to a public examples repo).Use placeholder host instead of the real internal IP, and remove all conflict markers:
Was this helpful? React with 👍 / 👎