Skip to content

Run tests on Blacksmith (runner migration pilot) - #47

Open
yakimoto wants to merge 1 commit into
mainfrom
blacksmith-runners
Open

yakimoto wants to merge 1 commit into
mainfrom
blacksmith-runners

Conversation

@yakimoto

@yakimoto yakimoto commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

User description

Pilot for org-wide ubuntu-latest migration. Trivial Node test workflow; merge after GitHub billing unlock (checks cannot run while account locked).


Note

Cursor Bugbot is generating a summary for commit 1490cbc. Configure here.

Summary by Sourcery

Enhancements:

  • Run the Node test workflow on the Blacksmith Ubuntu runner as part of the runner migration pilot.

Review in cubic


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


CodeAnt-AI Description

Run automated tests on the Blacksmith Ubuntu runner

What Changed

  • The Node.js test workflow now runs on the Blacksmith 2-vCPU Ubuntu 24.04 runner instead of the default GitHub-hosted Ubuntu runner

Impact

✅ Tests run on the Blacksmith runner

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

@sourcery-ai

sourcery-ai Bot commented Sep 15, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This pilot changes the workflow's test job to execute on Blacksmith's blacksmith-2vcpu-ubuntu-2404 runner instead of ubuntu-latest, without otherwise altering the test workflow.

File-Level Changes

Change Details Files
Migrate the test job from GitHub-hosted Ubuntu to Blacksmith's 2-vCPU Ubuntu 24.04 runner.
  • Replace the workflow runner label for the Node test job.
  • Keep the existing checkout and test steps unchanged.
.github/workflows/test.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@codeant-ai

codeant-ai Bot commented Sep 15, 2026

Copy link
Copy Markdown

🤖 CodeAnt AI — Review Status

Status Commit Started (UTC) Finished (UTC)
✅ Reviewed your PR 1490cbc Sep 15, 2026 · 19:43 19:44

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because your workspace is out of credits. Ask your workspace admin to add credits to resume reviews. Manage billing

@codeant-ai

codeant-ai Bot commented Sep 15, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@coderabbitai

coderabbitai Bot commented Sep 15, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 9da78682-d6c7-4af4-be03-b13b65ff978b

📥 Commits

Reviewing files that changed from the base of the PR and between 6d9a18b and 1490cbc.

📒 Files selected for processing (1)
  • .github/workflows/test.yml

Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (8)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: cubic · AI code reviewer
  • GitHub Check: Cursor Bugbot
  • GitHub Check: Macroscope - Approvability Check
  • GitHub Check: Cursor Approval Agent: Pull Request Router and Approver
  • GitHub Check: Macroscope - Approvability Check
  • GitHub Check: Cursor Security Agent: Security Reviewer
  • GitHub Check: semgrep-cloud-platform/scan
🧰 Additional context used
🪛 actionlint (1.7.12)
.github/workflows/test.yml

[error] 18-18: label "blacksmith-2vcpu-ubuntu-2404" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2025-vs2026", "windows-2022", "windows-11-arm", "ubuntu-slim", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "macos-latest", "macos-latest-xlarge", "macos-latest-large", "macos-26-intel", "macos-26-xlarge", "macos-26-large", "macos-26", "macos-15-intel", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xlarge", "macos-14-large", "macos-14", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file

(runner-label)

🔇 Additional comments (1)
.github/workflows/test.yml (1)

18-18: 🩺 Stability & Availability

blacksmith-2vcpu-ubuntu-2404 is a nonstandard runner label. If no repository-accessible runner provides that label, GitHub Actions cannot schedule the test job. The repository does not expose the Blacksmith registration, so this availability condition cannot be decided. If actionlint runs elsewhere, its documented configuration also requires this custom label in actionlint.yaml; no such configuration is present in the repository.


📝 Summary

Summary by CodeRabbit

  • Chores
    • Updated the automated test environment to use a standardized Ubuntu runner.

Walkthrough

The test job now runs on blacksmith-2vcpu-ubuntu-2404 instead of ubuntu-latest.

Changes

Test runner update

Layer / File(s) Summary
Test runner selection
.github/workflows/test.yml
The test job runner changed to blacksmith-2vcpu-ubuntu-2404.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 1490c

No repository-confirmed merge-blocking issue was found. Verify the Blacksmith runner is enabled in GitHub settings before relying on this workflow.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies the main change: migrating test execution to the Blacksmith runner as a pilot.
Description check ✅ Passed The description directly explains the Blacksmith runner migration pilot and its billing-related merge condition.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch blacksmith-runners
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch blacksmith-runners

Comment @coderabbitai help to get the list of available commands.

@codeant-ai codeant-ai Bot added the size:XS This PR changes 0-9 lines, ignoring generated files label Sep 15, 2026

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Needs a human reviewer. Tests and any workflow credentials will now execute on a Blacksmith runner rather than GitHub-hosted infrastructure, adding a third-party execution and trust boundary. If that runner is misconfigured or compromised, repository contents or available secrets could be exposed, and reverting would not undo any exposure; a failure would also block CI until the runner is restored or the change is reverted.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@gitar-bot

gitar-bot Bot commented Sep 15, 2026

Copy link
Copy Markdown

Note

Automatic reviews are paused because your team has used its included automatic processing for this billing period (headroom scales with your seat count). You can still comment "Gitar review" to run one anytime, and automatic reviews resume on their own by October 1. Add seats for more headroom.
Learn more

Code Review ✅ Approved

Workflow migrated to run Node tests on the Blacksmith Ubuntu runner as part of the org-wide runner migration pilot. No issues found.

Review coverage

Rules No rules evaluated

Functional validation Not enabled · Set up

Options

Display: compact → Counting what did not apply, without listing it.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk: medium. Approved based on a clean Cursor Bugbot check and a clean Cursor Security Agent check for this one-line test runner swap. No reviewers assigned.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver

@macroscopeapp

macroscopeapp Bot commented Sep 15, 2026

Copy link
Copy Markdown

Approvability

Verdict: Would Approve

Macroscope's review found this PR approvable — This PR only moves the existing test workflow to a Blacksmith Ubuntu runner; application behavior, deployment targets, and customer request paths remain unchanged. Its scope is limited to minor CI/CD configuration.

Not approved because:

  • Credit balance exhausted. Approvability relies on correctness review in order to determine eligibility

Review your spending limits in Billing settings. You can add or adjust custom eligibility rules. Learn more.

@yakimoto
yakimoto enabled auto-merge September 15, 2026 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant