Skip to content

smoke-install.yml: tools/list count is hardcoded (18) and already stale on main (19 since voice-tool) #122

Description

@yakimoto

Receipt: the most recent smoke-install run on main (https://github.com/wave-av/mcp-server/actions/runs/33905925774) fails with FAIL expected 18 tools, got 19 because the voice tool added a 19th tool and the constant in .github/workflows/smoke-install.yml was not bumped.

PR #121 (design tools, 4 more) bumps the constant to 23 on its branch, so merging #121 fixes main by side effect; if #121 is not merged first, main needs its own bump to 19.

Better fix (follow-up): derive the expected count from the registered tool list (e.g. scripts/smoke-mcp.mjs reads it from the built server, or the workflow greps src/tools/index.ts) so the constant can never go stale again. The --all step's separate rows.length !== 18 assertion covers only the 18 gateway-backed tools and is intentionally unrelated.

Type: bug · Area: ci · Priority: P2

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    category:bugSomething is brokenneeds-triageOn the board but missing Type/Area/Prioritytrust:ownerIssue author is repo owner

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions