Skip to content

chore: make CODEOWNERS resolvable and move it to .github/ - #140

Open
yakimoto wants to merge 1 commit into
mainfrom
chore/codeowners
Open

yakimoto wants to merge 1 commit into
mainfrom
chore/codeowners

Conversation

@yakimoto

@yakimoto yakimoto commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

User description

What

Replace the unresolvable CODEOWNERS in this repository with one GitHub can actually enforce, and move it from the repository root to .github/CODEOWNERS.

Why

GET /repos/wave-av/sdk/codeowners/errors on main currently reports 3 "Unknown owner" error(s) - every owner line in the existing file names a team that either does not exist in this organization or has no write access to this repository. GitHub silently ignores such lines, which means:

  • no reviewer is ever auto-requested on pull requests, and
  • any branch rule that requires Code Owner review can never be satisfied, because there is no code owner to give it.

That second point is the operational problem: a PR gated on Code Owner approval would sit unmergeable without an admin override.

Change

  • CODEOWNERS (root) -> .github/CODEOWNERS. GitHub checks .github/ first, then the root, then docs/; keeping a single file in the highest-precedence location avoids a stale shadow copy.
  • Default owner is the organization owner (@yakimoto), whose permission on this repository was verified via GET /repos/wave-av/sdk/collaborators/yakimoto/permission -> admin. No organization team currently holds write on this repository, so a team handle would be ignored exactly like the old one. When a team is granted write here, swapping the handle is a one-line follow-up.
  • Explicit entries for the release-critical surfaces that exist in this repository (CI workflows, package manifest, release scripts, and the ownership file itself), so those paths keep an owner even if the default rule is later loosened.

Resulting file:

# CODEOWNERS - GitHub auto-requests review from the listed owners on matching paths.
# Every handle here must be a user or team with write access to this repository;
# an unresolvable handle is silently ignored and any "require Code Owner review"
# rule becomes unsatisfiable. Validate after editing:
#   gh api repos/wave-av/sdk/codeowners/errors    # expect {"errors":[]}
# Later rules take precedence over earlier ones.

# Default owner for everything.
*                       @yakimoto

# Release-critical surfaces: CI/CD, package manifest, release tooling, ownership.
/.github/workflows/    @yakimoto
/.github/dependabot.yml @yakimoto
/package.json           @yakimoto
/scripts/release/       @yakimoto
/.github/CODEOWNERS     @yakimoto

Verification

  • gh api repos/wave-av/sdk/codeowners/errors?ref=chore/codeowners on this branch returns: {"errors":[]}
  • Head SHA: 2cb1077ec46f1f0a56432d4f0fd9d2bda09f89ce

Notes

  • GitHub Actions is currently billing-locked for this organization, so no workflow runs will appear on this PR; the CODEOWNERS validation above is done through the REST API, which does not depend on Actions.
  • This PR does not change branch protection or rulesets. It only makes the existing ownership file resolvable.
  • No secrets, tokens, or credentials are involved; the file contains a GitHub login and path globs only.

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Note

Low Risk
Repository governance metadata only; no runtime, auth, or application logic changes.

Overview
Moves code ownership configuration to .github/CODEOWNERS and replaces unresolvable team handles so GitHub can actually request reviewers and satisfy Code Owner branch rules.

The root CODEOWNERS file is removed. A new .github/CODEOWNERS sets @yakimoto as the default owner and adds explicit rules for release-sensitive paths (workflows, Dependabot config, package.json, release scripts, and the ownership file itself). Comments document how to validate owners via the codeowners/errors API.

Reviewed by Cursor Bugbot for commit 2cb1077. Bugbot is set up for automated code reviews on this repo. Configure here.

Review in cubic


CodeAnt-AI Description

Make GitHub code ownership reviews work for this repository

What Changed

  • Moves the ownership rules to .github/CODEOWNERS, where GitHub can discover and enforce them
  • Routes all files and release-critical paths to a repository owner with write access
  • Removes the previous rules that referenced an unresolved team, allowing required Code Owner reviews to be satisfied

Impact

✅ Working automatic reviewer requests
✅ Satisfiable Code Owner approval requirements
✅ Protected review for release-critical files

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

The previous CODEOWNERS named a team GitHub could not resolve on this repository, so every line was reported as "Unknown owner" and any rule requiring Code Owner review had no one who could satisfy it. Replace it with an owner that has verified write access, move it to .github/CODEOWNERS (the highest-precedence location), and add explicit entries for the release-critical surfaces present here (workflows, package manifest, release scripts).

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@codeant-ai

codeant-ai Bot commented Sep 11, 2026

Copy link
Copy Markdown

🤖 CodeAnt AI — Review Status

Status Commit Started (UTC) Finished (UTC)
✅ Reviewed your PR 2cb1077 Sep 11, 2026 · 18:31 18:33

@sourcery-ai

sourcery-ai Bot commented Sep 11, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Relocates CODEOWNERS to .github/ and replaces ignored team owners with the verified repository administrator, while adding explicit release-surface rules so GitHub can auto-request and enforce code-owner reviews.

File-Level Changes

Change Details Files
Replace the unresolvable root CODEOWNERS with a GitHub-enforced ownership file in the highest-precedence supported location.
  • Move the file from the repository root to .github/CODEOWNERS without retaining a shadow copy.
  • Assign @yakimoto as the default owner, relying on verified repository write access.
  • Add explicit ownership rules for workflows, Dependabot configuration, package metadata, release scripts, and the CODEOWNERS file itself.
  • Document handle-resolution requirements and the REST API validation command.
CODEOWNERS
.github/CODEOWNERS

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@codeant-ai

codeant-ai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@cursor

cursor Bot commented Sep 11, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_50ed5744-3919-40be-aafd-70cc2458f502)

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Team

Run ID: a4dab492-c673-4251-95c1-468000068482

📥 Commits

Reviewing files that changed from the base of the PR and between 3aec164 and 2cb1077.

📒 Files selected for processing (2)
  • .github/CODEOWNERS
  • CODEOWNERS
💤 Files with no reviewable changes (1)
  • CODEOWNERS

Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (5)
  • GitHub Check: cubic · AI code reviewer
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: Sourcery review
  • GitHub Check: Macroscope - Approvability Check
  • GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (1)
.github/CODEOWNERS (1)

1-16: LGTM!


📝 Summary

Summary by CodeRabbit

  • Chores
    • Updated repository maintenance and review-routing configuration.
    • No changes to application functionality or the end-user experience.

Walkthrough

The pull request removes the root CODEOWNERS file and adds .github/CODEOWNERS. The new file documents ownership resolution and assigns @yakimoto to repository paths and selected release-critical files.

Changes

Ownership routing

Layer / File(s) Summary
CODEOWNERS rule replacement
.github/CODEOWNERS, CODEOWNERS
The root CODEOWNERS rules are removed. A documented .github/CODEOWNERS file assigns @yakimoto to all paths and selected CI/CD, Dependabot, package, release, and ownership files.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 2cb10

Ownership routing is updated without changing runtime code or deployment behavior, and the reported CODEOWNERS validation succeeded.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: making CODEOWNERS resolvable and moving it to .github/.
Description check ✅ Passed The description includes complete What and Why sections, detailed implementation context, verification results, and impact. It omits the template's Checklist section, but the description is otherwise …
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/codeowners
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch chore/codeowners

Warning

source "DeepWiki" unavailable: no selected tools are declared read-only by the MCP server


source "DeepWiki" unavailable: no selected tools are declared read-only by the MCP server


Comment @coderabbitai help to get the list of available commands.

@codeant-ai codeant-ai Bot added the size:S This PR changes 10-29 lines, ignoring generated files label Sep 11, 2026
@gitar-bot

gitar-bot Bot commented Sep 11, 2026

Copy link
Copy Markdown

Note

Automatic reviews are paused because your team has used its included automatic processing for this billing period (headroom scales with your seat count). You can still comment "Gitar review" to run one anytime, and automatic reviews resume on their own by October 1. Add seats for more headroom.
Learn more

Code Review ✅ Approved

Moves code ownership configuration to .github/CODEOWNERS and replaces unresolvable team handles with @yakimoto, enabling GitHub to auto-request reviewers and satisfy Code Owner branch rules. Verified via codeowners/errors API to return no errors. No issues found.

Options

Display: compact → Counting what did not apply, without listing it.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because your workspace is out of credits. Ask your workspace admin to add credits to resume reviews. Manage billing

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@macroscopeapp

macroscopeapp Bot commented Sep 11, 2026

Copy link
Copy Markdown

Approvability

Verdict: Would Approve

Macroscope's review found this PR approvable — This PR only relocates and corrects repository CODEOWNERS metadata so GitHub can resolve ownership and enforce review routing. It contains no application, runtime, schema, deployment, security, or billing changes, and all changed files are owned by the author.

Not approved because:

  • Credit balance exhausted. Approvability relies on correctness review in order to determine eligibility

Review your spending limits in Billing settings. You can add or adjust custom eligibility rules. Learn more.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.
Architecture diagram
sequenceDiagram
    participant Dev as Developer
    participant GH as GitHub Platform
    participant CO as CODEOWNERS Engine
    participant Repo as Repository Config
    participant API as GitHub REST API
    participant PR as Pull Request System
    participant Branch as Branch Protection

    Note over Dev,GH: Repository Governance Configuration Flow
    
    Dev->>GH: Push changes to repository
    GH->>Repo: Locate CODEOWNERS file
    alt Search precedence order
        Repo-->>GH: .github/CODEOWNERS (highest precedence)
    else Fallback locations
        Repo-->>GH: Root CODEOWNERS or docs/CODEOWNERS
    end
    
    Note over GH,CO: Owner Resolution & Validation
    
    GH->>CO: Parse ownership rules
    CO->>CO: Match paths to patterns
    CO->>GH: Validate owner handles exist
    alt Valid owner (@yakimoto with admin access)
        GH-->>CO: Owner resolvable
    else Invalid owner (unresolvable team)
        GH-->>CO: Silent ignore, no owner assigned
    end
    
    Note over GH,API: Rule Configuration & Enforcement
    
    Dev->>API: Query codeowners validation
    API->>CO: GET /repos/wave-av/sdk/codeowners/errors
    CO-->>API: {"errors":[]}
    API-->>Dev: Validation result
    
    Note over PR,Branch: PR Review & Protection Flow
    
    Dev->>GH: Create pull request
    GH->>PR: Identify changed files
    PR->>CO: Match files to ownership rules
    CO-->>PR: Owner(s) for each path
    
    alt Owner found
        PR->>GH: Auto-request review from @yakimoto
        GH-->>PR: Reviewer assigned
    else No owner (unresolvable handle)
        PR-->>GH: No reviewer requested
        GH-->>Branch: Block due to unsatisfied review
    end
    
    Branch->>CO: Check Code Owner review requirement
    alt Code Owner approved
        CO-->>Branch: Approval valid
        Branch-->>PR: Ready to merge
    else Code Owner review pending
        Branch-->>PR: Merge blocked
        PR-->>GH: Wait for owner approval
    end
    
    Note over CO,Repo: Explicit Path Coverage
    
    CO->>Repo: Default rule (*) → @yakimoto
    CO->>Repo: /.github/workflows/ → @yakimoto
    CO->>Repo: /.github/dependabot.yml → @yakimoto
    CO->>Repo: /package.json → @yakimoto
    CO->>Repo: /scripts/release/ → @yakimoto
    CO->>Repo: /.github/CODEOWNERS → @yakimoto
Loading

Re-trigger cubic

@yakimoto
yakimoto enabled auto-merge September 12, 2026 16:46
@yakimoto
yakimoto disabled auto-merge September 12, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant