Skip to content

chore(deps): update rust crate rand to 0.10 #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renovate wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(deps): update rust crate rand to 0.10 #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk-rust/wave-x402/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ repository = "https://github.com/wave-av/sdks"
serde = { version = "1", features = ["derive"] }
serde_json = "1"
base64 = "0.22"
rand = "0.8"
rand = "0.10"

@devin-ai-integration devin-ai-integration Bot Aug 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Verify rand 0.10 still exposes rand::rngs::OsRng + RngCore as used by random_nonce

The only consumer of rand in this crate is random_nonce() (sdk-rust/wave-x402/src/lib.rs:133-136), which calls rand::rngs::OsRng.fill_bytes(&mut b) with use rand::RngCore; (sdk-rust/wave-x402/src/lib.rs:34). Across recent rand major releases the OS RNG surface has moved/renamed repeatedly (e.g. OsRng gated behind the os_rng feature, fill_bytes moving between RngCore/TryRngCore). A major bump to 0.10 should be validated with an actual cargo build -p wave-x402 && cargo test -p wave-x402 (there is no Cargo.lock checked in, so CI resolves fresh), and if the OS RNG API changed, random_nonce must be updated — a silently fallible/blocking path here would affect nonce generation for every payment authorization.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

alloy = { version = "2.0.5", features = ["sol-types", "signer-local"] }
# alloy provides EIP-712 typed-data hashing (sol! + SolStruct) and local key signing.

Expand Down
Loading