Conversation
… isolation marker
All 7 checks the registry clean-room gate (run 33933317710) reported failing were
already root-cause fixed in source before this change, across three repositories
(verified independently in this lane, not merely re-read from docs):
- @wave-av/cli npm-provenance-attested / bin-version-matches-package /
declared-dep-ranges-pinned: fixed on wave-av/cli's origin/main (release.yml already
runs `npm publish --provenance` under `id-token: write` OIDC; src/lib/version.ts
derives CLI_VERSION from package.json at runtime; @wave-av/sdk pinned to exact
"2.0.14"). Owned by a different repository; nothing to change here.
- wave-sdk (PyPI) py-import-module / py-no-stdlib-shadow: fixed on
wave-av/sdk-python's origin/main (module renamed wave -> wave_sdk, version 2.1.0,
with its own tests/test_packaging.py + smoke-install.yml). Owned by a different
repository; nothing to change here.
- wave-av-sdk (PyPI) py-import-module / py-no-stdlib-shadow: fixed on THIS repo's
origin/main already (sdk-python/ renamed wave/ -> wave_sdk/, version 3.0.0).
Re-verified here by actually building the wheel, installing it into a fresh venv,
and running scripts/ga/cleanroom_python_assert.py against the installed artifact —
py-import-module and py-no-stdlib-shadow both pass; full pytest suite 31/31 (36/36
with the new tests below).
None of the above needed a source change; all are blocked solely on an operator
publish, which this lane may not perform.
What this commit actually changes:
1. scripts/ga/cleanroom_python_assert.py: the cleanroom-isolation guard keyed its
repo-checkout-on-sys.path detection on a hardcoded "wave" directory name. That was
the PRE-rename package directory; after wave -> wave_sdk landed (in the same source
fix this file is supposed to help verify), the guard silently stopped matching
either checkout's real layout and could never again detect a genuine repo-on-path
leak. Demonstrated the regression directly: with PYTHONPATH pointed at the repo
root, the old code reports cleanroom-isolation ok=true (wrong); the fix (keyed on
`args.module`, the same name already used for the import check) reports ok=false
(correct). Re-ran the full probe against a real built wheel afterward to confirm it
still passes cleanroom-isolation / py-import-module / py-no-stdlib-shadow.
2. sdk-python/tests/test_packaging.py (new): offline packaging guards — no shipped
top-level package may shadow a stdlib name, `import wave` (bare) still resolves to
the stdlib from inside the checkout, `wave_sdk.__version__` matches
pyproject.toml's version, and the distribution name is still `wave-av-sdk`. These
run in the normal `pytest` pass, before any wheel is ever built — closing the gap
that let 2.0.0 ship broken in the first place (an editable install / repo-checkout
test run hides the exact stdlib-shadow class this guards). Mirrors the equivalent
guard already proven out in wave-av/sdk-python's tests/test_packaging.py, adapted
to this package's name/module. pyproject.toml gains the matching `tomli` dev-extra
for Python < 3.11 (tomllib is stdlib only from 3.11).
3. .github/workflows/test-python.yml: new `smoke-install` job — builds the real wheel,
installs it (no `-e`, no repo on sys.path) into a throwaway venv, and runs THIS
repo's own scripts/ga/registry-cleanroom.mjs probe (cleanroom_python_assert.py)
against the installed artifact on every PR touching sdk-python. This is the same
probe the GA gate runs against the live PyPI package after a publish — the
difference is this one runs pre-publish, offline, on every PR, so the wave/wave_sdk
defect class cannot reach a registry a second time. Verified end-to-end locally:
built the wheel, installed into a fresh venv, ran the exact copy/probe/parse
sequence the job runs — all three checks (cleanroom-isolation, py-import-module,
py-no-stdlib-shadow) pass; actionlint clean on the workflow file.
Verified: `pytest -q` sdk-python 36/36 pass (31 pre-existing + 5 new); `ruff check
tests/test_packaging.py` clean; `actionlint .github/workflows/test-python.yml` clean;
manual wheel build + fresh-venv install + cleanroom_python_assert.py probe pass
against the real built artifact, both before and after the isolation-marker fix (with
the fix demonstrated to catch a real injected leak the old code missed).
Tracking: claude-workstation#4321 item 6.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MLCfz2w3xiGLfFFgFmbe5j
|
Your free trial PR review limit of 300 PRs has been reached. Please upgrade your plan to continue using CodeAnt AI. |
|
ⓘ Qodo reviews are paused because your workspace is out of credits. Ask your workspace admin to add credits to resume reviews. Manage billing |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @yakimoto, this account has used its review budget of 2,500,000 diff characters for the last 7 days.
You can request another review in 22 hours and 48 minutes by commenting @sourcery-ai review.
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_b479bfc2-c5df-4549-9ab9-4db2bd400765) |
Reviewer's GuideAdds pre-publish safeguards for the Python SDK by fixing the stale repository-isolation marker, testing packaging metadata and stdlib-shadowing risks offline, and exercising the real wheel in a clean virtual environment on pull requests. Sequence diagram for pre-publish Python wheel smoke validationsequenceDiagram
participant CI as GitHub Actions
participant Build as Wheel Builder
participant Venv as Fresh Virtualenv
participant Probe as cleanroom_python_assert.py
CI->>Build: python -m build --wheel
Build-->>CI: wave-av-sdk wheel
CI->>Venv: Install wheel without editable mode
Venv->>Probe: Run probe with --dist wave-av-sdk --module wave_sdk --symbol Wave
Probe->>Probe: Check cleanroom-isolation
Probe->>Probe: Check py-import-module
Probe->>Probe: Check py-no-stdlib-shadow
Probe-->>CI: Report clean-room checks
Flow diagram for offline Python packaging safeguardsflowchart LR
Checkout[Repository checkout] --> Tests[pytest packaging guards]
Tests --> Metadata[Validate distribution and version metadata]
Tests --> Imports[Validate wave_sdk import and Wave symbol]
Tests --> Stdlib[Validate import wave resolves to stdlib]
Tests --> Wheel[Build real wheel]
Wheel --> Install[Install into fresh virtualenv]
Install --> Probe[Run cleanroom_python_assert.py]
Probe --> Publish[Safe to publish]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — The PR is limited to CI, tests, development metadata, and GA clean-room tooling, with no changes to customer-facing SDK runtime behavior. Human review is appropriate because every changed file is owned by the sdk-owners team rather than the PR author. Not approved because:
Review your spending limits in Billing settings. You can add or adjust custom eligibility rules. Learn more. |
|
Note Automatic reviews are paused because your team has used its included automatic processing for this billing period (headroom scales with your seat count). You can still comment "Gitar review" to run one anytime, and automatic reviews resume on their own by October 1. Add seats for more headroom. Code Review ✅ ApprovedFixes the OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (4)
Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour. 📜 Recent review details⏰ Context from checks skipped due to timeout. (3)
|
| Layer / File(s) | Summary |
|---|---|
Packaging regression tests sdk-python/tests/test_packaging.py, sdk-python/pyproject.toml |
The tests validate wave_sdk, standard-library import resolution, package-name collisions, version metadata, and distribution naming. Python versions below 3.11 use tomli. |
Module-aware clean-room detection scripts/ga/cleanroom_python_assert.py |
The clean-room check derives the expected repository package directory from the requested module name. |
Isolated CI smoke installation .github/workflows/test-python.yml |
CI builds and installs the SDK wheel in isolated Python 3.10 and 3.12 environments, then runs the clean-room probe. |
Estimated code review effort: 3 (Moderate) | ~25 minutes
Merge Risk: ⚪ Minimal · up to 80576
This change repairs the clean-room package check and adds packaging and isolated-install validation for the Python SDK. No merge-blocking risk is currently identified.
Sequence Diagram(s)
sequenceDiagram
participant GitHub Actions
participant Wheel Builder
participant Isolated Virtualenv
participant Clean-room Probe
GitHub Actions->>Wheel Builder: Build SDK wheel
Wheel Builder->>Isolated Virtualenv: Install wheel
Isolated Virtualenv->>Clean-room Probe: Run import checks
Clean-room Probe-->>GitHub Actions: Return check results
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage | Docstring coverage is 77.78% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 9 functions across 2 files. (2 skipped: 2… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (4 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title accurately identifies the clean-room wheel-import guard and stale isolation-marker fix. It is specific and related to the main changes. |
| Description check | ✅ Passed | The description clearly explains the workflow fix, packaging tests, smoke-install job, verification results, and out-of-scope republishing work. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
Full details: Docstring Coverage
Explanation
Docstring coverage is 77.78% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 9 functions across 2 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches 💡 2
📝 Generate docstrings 💡
- Create stacked PR
- Commit on current branch
🛠️ Fix failing CI checks 💡
- Create stacked PR
- Commit on current branch
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Commit unit tests in branch
fix/cleanroom-registry-defects
✨ Simplify code
- Create PR with simplified code
- Commit simplified code in branch
fix/cleanroom-registry-defects
Comment @coderabbitai help to get the list of available commands.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 4 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Architecture diagram
sequenceDiagram
participant Dev as Developer
participant GH as GitHub Actions
participant Unit as pytest (sdk-python)
participant Pack as test_packaging.py
participant Build as Wheel Build
participant Venv as Fresh Venv
participant Probe as cleanroom_python_assert.py
participant Registry as GA Registry Gate (post-publish)
Note over Dev,Registry: PR-time Guard Flow (new smoke-install job)
Dev->>GH: Push PR touching sdk-python/**
GH->>GH: Trigger test-python.yml
rect rgb(240, 248, 255)
Note over Unit,Pack: Offline unit tests (existing job)
GH->>Unit: Run pytest
Unit->>Pack: Execute test_packaging.py
Pack->>Pack: Scan top-level packages for stdlib shadow (NEW)
alt Stdlib collision found
Pack-->>Unit: FAIL (e.g., wave/ reappears)
else No collision
Pack->>Pack: Verify import wave resolves to stdlib
Pack->>Pack: Check wave_sdk.__version__ vs pyproject
Pack->>Pack: Confirm dist name is wave-av-sdk
Pack-->>Unit: Pass
end
end
rect rgb(245, 245, 245)
Note over GH,Probe: New smoke-install job (pre-publish, offline)
GH->>Build: Build real wheel (python -m build)
Build-->>GH: wheel file
GH->>Venv: Create throwaway venv (no repo on sys.path)
GH->>Venv: Install wheel (pip install, no -e)
GH->>Venv: Copy cleanroom probe into venv
Venv->>Probe: Run probe (--module wave_sdk)
Note over Probe: Isolation guard keyed on args.module (CHANGED)
alt Repo checkout leaks onto sys.path
Probe-->>Venv: cleanroom-isolation ok=false (now correctly detects)
Venv-->>GH: FAIL (guard catches leak)
else Clean environment
Probe->>Probe: Import wave_sdk
Probe->>Probe: Check no stdlib shadow
Probe-->>Venv: All checks pass
Venv-->>GH: Pass
end
end
Note over Registry: Post-publish (unchanged, out of scope)
GH->>Registry: Publish wave-av-sdk to PyPI (operator action)
Registry->>Registry: Run same probe against live registry
Note over Registry: Uses same cleanroom_python_assert.py — now with fixed isolation marker
…estable
The `cleanroom-isolation` check is the load-bearing assertion of the registry
clean-room gate: `py-import-module` and `py-no-stdlib-shadow` only mean anything
if no source checkout can satisfy the import the PUBLISHED wheel is supposed to
satisfy. It was keyed on one hardcoded path.
The first fix on this branch replaced the stale `<entry>/sdk-python/wave` literal
with `<entry>/sdk-python/<module>`. That restores the guard for wave-av/sdks'
own layout only. The probe also runs against wave-av/sdk-python, whose package
sits at the REPOSITORY ROOT (`wave_sdk/`, verified on that repo's origin/main) —
a checkout of it on sys.path still passed the guard. Measured, both directions:
fake root-level checkout on PYTHONPATH, probe at this branch's head
cleanroom-isolation ok=true (wrong — leak invisible)
same sys.path, probe after this commit
cleanroom-isolation ok=false REPO ON sys.path: [.../wave_sdk]
`checkout_paths_providing()` now asks the layout-independent question — can this
sys.path entry supply the module under test, at the entry itself or under any of
the conventional source roots — after excluding the entries that legitimately
can (site-packages, stdlib, user-site, the venv prefix), read from sysconfig and
`site` rather than assumed to sit under sys.prefix. It also resolves the `''`
entry to cwd, which the previous code skipped outright.
cleanroom-targets.mjs now COPIES the probe into the throwaway room before running
it. Python unconditionally prepends the executed script's directory to sys.path,
so running it in place put `<repo>/scripts/ga` first on the path of every
clean-room probe — a repository directory inside the clean room, which is the one
thing this suite promises never happens. (`-P`/PYTHONSAFEPATH is 3.11+; the
venv's interpreter version is not ours to assume.) test-python.yml's
smoke-install job already copies it for exactly this reason.
sdk-python/tests/test_cleanroom_probe.py: 8 offline unit tests over real
directory trees — both repository layouts, single-file module, the cwd entry, the
site-packages false-positive control, and the self-maintenance property (rename
the package and the guard follows it). A hardcoded-path guard had no test that
could catch it going blind; that is why the rename disarmed it silently.
Verification in this lane:
- pytest -q in sdk-python: 44/44 pass (36 before this commit + 8 new)
- ruff check under the repo's own config: clean on both changed/added files
- full pypi clean-room gate re-run against the LIVE registries with these
changes: identical evidence fingerprint 8e6537fd84b4859d003e6787d3c4b585ceb5
ee39da5e681d4d4f2cb098cc8e04 to the run at this branch's head and to
origin/main — the hardening changes no verdict on real artifacts
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MLCfz2w3xiGLfFFgFmbe5j
|
Your free trial PR review limit of 300 PRs has been reached. Please upgrade your plan to continue using CodeAnt AI. |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_931c09c3-2ff8-470e-a149-d0ddac726449) |
Clean-room triage 2026-09-05 — the red
|
| # | Artifact | Check | Bucket | Status today |
|---|---|---|---|---|
| 1 | @wave-av/cli@1.0.8 |
npm-provenance-attested |
(a) real artifact defect | still failing — #85 |
| 2 | @wave-av/cli@1.0.8 |
bin-version-matches-package |
(a) real artifact defect | still failing — #85 |
| 3 | @wave-av/cli@1.0.8 |
declared-dep-ranges-pinned |
(a) real artifact defect | still failing — #85 |
| 4 | wave-sdk@2.0.0 (PyPI) |
py-import-module |
(a) real artifact defect | still failing — #86 |
| 5 | wave-sdk@2.0.0 (PyPI) |
py-no-stdlib-shadow |
(a) real artifact defect | still failing — #86 |
| 6 | wave-av-sdk (PyPI) |
py-import-module |
(a) real artifact defect | PASS since 3.0.0 |
| 7 | wave-av-sdk (PyPI) |
py-no-stdlib-shadow |
(a) real artifact defect | PASS since 3.0.0 |
Nothing lands in bucket (c) "introduced by this PR".
Control against main
The gate was run against origin/main (6fe7c01) in a clean detached worktree and against this branch's head, same interpreter, same live registries. Identical verdict and identical evidence fingerprint 8e6537fd84b4859d003e6787d3c4b585ceb5ee39da5e681d4d4f2cb098cc8e04. In CI the same failing set appears on two unrelated Renovate branches (runs 33933317710, 33933289317) whose only diff from main is sdk-typescript/pnpm-lock.yaml.
The second guard defect, fixed in b419a85
The first commit replaced the stale <entry>/sdk-python/wave literal with <entry>/sdk-python/<module>. That restores the guard for this repository's layout only. The probe also runs against wave-av/sdk-python, whose package sits at the repository root (wave_sdk/, verified on that repo's main), so a checkout of it on sys.path still passed the guard. Measured with a fabricated checkout on PYTHONPATH:
| probe revision | root-level wave_sdk/ |
sdk-python/wave_sdk/ |
|---|---|---|
origin/main |
ok=true (blind) |
ok=true (blind) |
this branch, 80576ba |
ok=true (still blind) |
ok=false |
this branch, b419a85 |
ok=false |
ok=false |
checkout_paths_providing() now asks the layout-independent question — can this sys.path entry supply the module under test, at the entry itself or under any conventional source root — after excluding the entries that legitimately can (site-packages, stdlib, user-site, venv prefix), read from sysconfig/site rather than assumed to sit under sys.prefix. It also resolves the '' entry to cwd, which the old code skipped outright.
The clean room was not actually clean
cleanroom-targets.mjs executed the probe from scripts/ga/. Python unconditionally prepends the executed script's directory to sys.path, so a repository directory was first on the path of every clean-room probe — the one thing the suite promises never happens. It is now copied into the throwaway room first, exactly as test-python.yml's smoke-install job already does.
sdk-python/tests/test_cleanroom_probe.py adds 8 offline unit tests over real directory trees: both repository layouts, single-file module, the cwd entry, the site-packages false-positive control, and the self-maintenance property (rename the package and the guard follows it). A hardcoded-path guard had no test that could catch it going blind, which is why the rename disarmed it silently.
Verification on b419a85
python test: all four jobs green (testandsmoke-install, 3.10 and 3.12)- local
pytest -qinsdk-python: 44/44 ruff checkunder the repo's own config: clean on both changed files and the new testregistry parity,license consistency,governance-enforce,public-repo-guard,foundation-gate: greencleanroom: red with exactly the 5 published-artifact defects above, evidence artifactga-evidence-registry-cleanroomon run33942707861
Still advisory
cleanroom is not a required status check on main. The only required context is Secrets + content policy (org ruleset public-repo-guard-required); classic branch protection 404s on this repo because it is ruleset-protected, and a sibling-repo control returns a populated list, so the short answer is a measurement rather than a permissions artifact. Tracked in #87 together with the stale "Arming window" ledger in GA-READINESS.md, which still reports 7 outstanding failures.
Deferred deliberately, not fixed here: all five live artifact defects (#85, #86) — no change in this repository can alter what a registry already serves, and both fixes need an operator-gated publish from a different repo. GA-READINESS.md's arming ledger was left alone too: its ART-001/VER-001/SUPPLY-001 blocks carry verified_revision and evidence sha256 fields that must be regenerated from a real run, not hand-edited (#87).
🤖 Generated with Claude Code
# Conflicts: # scripts/ga/cleanroom-targets.mjs
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_2244b286-04d4-461e-9177-b1f47243d578) |
codeant-ai
Bot
added
the
size:L
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
| branches: [main] | ||
| paths: | ||
| - "sdk-python/**" | ||
| - "scripts/ga/cleanroom_python_assert.py" |
There was a problem hiding this comment.
Suggestion: The push filter adds the probe path but not this workflow file, so workflow-only changes merged to main will not run the smoke-install gate. [logic error]
Assessment: 🟠 Major · 🔁 Occurrence: Rarely
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** .github/workflows/test-python.yml
**Line:** 16:16
**Comment:**
*Logic Error: The push filter adds the probe path but not this workflow file, so workflow-only changes merged to `main` will not run the smoke-install gate.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
CodeAnt Nitpicks1 code suggestion1.
|
1 participant
User description
Summary
Tracking: claude-workstation#4321 item 6 — fix the SOURCE causes of the
wave-av/sdksregistry clean-room acceptance failures (run 33933317710, 7 checks failing across 6 published artifacts).Finding, independently re-verified in this lane (not taken on trust from existing docs): all 7 failing checks were already root-cause fixed in source before this PR, spread across three repositories, and every one is blocked solely on an operator-triggered publish this lane may not perform:
@wave-av/clinpm-provenance-attestedrelease.ymlalready runsnpm publish --provenanceunderid-token: writeOIDCwave-av/cliorigin/main(verified:.github/workflows/release.yml)@wave-av/clibin-version-matches-packagesrc/lib/version.tsderivesCLI_VERSIONfrompackage.jsonat runtime instead of a hardcoded literalwave-av/cliorigin/main(verified directly)@wave-av/clideclared-dep-ranges-pinned@wave-av/sdkpinned to exact2.0.14(was^2.0.11)wave-av/clipackage.jsononorigin/main(verified directly)wave-sdk(PyPI)py-import-module/py-no-stdlib-shadowwave→wave_sdkwave-av/sdk-pythonorigin/main, version2.1.0(verified directly — separate repo, confirmed via the live package's ownproject_urls.Repository)wave-av-sdk(PyPI)py-import-module/py-no-stdlib-shadowsdk-python/in this repo, version3.0.0origin/mainbefore this PRscripts/ga/cleanroom_python_assert.pyagainst the installed artifact — both checks pass;pytest31/31 (36/36 with the new tests this PR adds)None of that needed a source change. What this PR actually changes:
Changes
scripts/ga/cleanroom_python_assert.py— thecleanroom-isolationguard (meant to catch a repo checkout accidentally onsys.path, which would make the whole clean-room probe meaningless) was keyed on a hardcoded"wave"directory name. That was the pre-rename package directory. Afterwave→wave_sdklanded, the guard silently stopped matching either checkout's real layout and could never again detect a genuine leak. Demonstrated the regression directly: withPYTHONPATHpointed at the repo root, the old code reportedcleanroom-isolation ok=true(wrong); the fix — keyed onargs.module, the same name already used for the import check — reportsok=false(correct). Re-ran the full probe against a real built wheel afterward to confirmcleanroom-isolation/py-import-module/py-no-stdlib-shadowstill all pass.sdk-python/tests/test_packaging.py(new) — offline packaging guards: no shipped top-level package may shadow a stdlib name, bareimport wavestill resolves to the stdlib from inside the checkout,wave_sdk.__version__matchespyproject.toml, and the distribution name is stillwave-av-sdk. These run in the normalpytestpass, before any wheel is built — closing the gap that let2.0.0ship broken in the first place (an editable install / repo-checkout test run hides exactly this class of stdlib-shadow bug, because the checkout directory winsimport waveunder pytest regardless of what the built wheel would actually ship). Mirrors the equivalent guard already proven out inwave-av/sdk-python'stests/test_packaging.py, adapted to this package's name/module.pyproject.tomlgains the matchingtomlidev-extra for Python < 3.11 (tomllibis stdlib only from 3.11)..github/workflows/test-python.yml— newsmoke-installjob: builds the real wheel, installs it (no-e, no repo onsys.path) into a throwaway venv, and runs this repo's owncleanroom_python_assert.pyprobe against the installed artifact, on every PR touchingsdk-python. This is the same probe the GA registry clean-room gate runs against the live PyPI package after a publish — the difference is this one runs pre-publish, offline, on every PR, so thewave/wave_sdkdefect class cannot reach a registry a second time.Verification performed (all run in this lane, not asserted from docs)
pytest -qinsdk-python: 36/36 pass (31 pre-existing + 5 new intest_packaging.py)ruff check tests/test_packaging.py: cleanactionlint .github/workflows/test-python.yml: cleanpython -m build --wheel), installed into a fresh venv with no repo checkout onsys.path, ran the actualscripts/ga/cleanroom_python_assert.py --dist wave-av-sdk --module wave_sdk --symbol Waveagainst it:cleanroom-isolation/py-import-module/py-no-stdlib-shadowall passPYTHONPATHpointed at the repo root reportscleanroom-isolation ok=falsewith the fix,ok=true(silently wrong) with the pre-fix codewave-av/cli'sorigin/mainalready carries the version-derivation, provenance, and exact-pin fixes, and thatwave-av/sdk-python'sorigin/mainalready carries thewave_sdkrename — both are separate repositories this PR cannot and does not touchWhat still requires a republish (explicitly out of scope for this lane)
All 7 originally-failing checks remain failing against the live registries until an operator publishes:
@wave-av/cli(npm),wave-sdk(PyPI, fromwave-av/sdk-python), andwave-av-sdk(PyPI, via asdk-python-v3.0.0tag on this repo). No npm/PyPI publish, git tag push, or workflow dispatch of a publish workflow was performed or attempted in this lane, per the hard constraint on this task.Test plan
pytest -qsdk-python: 36/36 passruff checkon new test file: cleanactionlinton modified workflow: cleansmoke-installjob on this PR (will run automatically; not yet observed since this PR was just opened)🤖 Generated with Claude Code
https://claude.ai/code/session_01MLCfz2w3xiGLfFFgFmbe5j
Note
Low Risk
Changes are limited to CI, GA clean-room tooling, and offline tests; they strengthen pre-publish checks without altering runtime SDK behavior or auth/data paths.
Overview
Hardens Python SDK packaging validation so stdlib-shadow and “repo on
sys.path” bugs are caught before PyPI, after thewave→wave_sdkrename had left a key clean-room check effectively always passing.cleanroom_python_assert.pyreplaces a hardcodedsdk-python/waveleak detector withcheckout_paths_providing()keyed on the module under test and common checkout layouts ("",sdk-python,src,python), treats''onsys.pathas cwd, and skips interpreter-owned paths (site-packages, stdlib, venv roots) so legitimate installs are not flagged.cleanroom-targets.mjsand the newsmoke-installCI job copy the probe into the throwaway environment before running it, because executing the script from the repo prependsscripts/gaontosys.pathand violated the same isolation promise.CI (
test-python.yml) addssmoke-install: build wheel → fresh venv → non-editable install → run the same JSON probe as registry clean-room (wave-av-sdk/wave_sdk/Wave) on Python 3.10 and 3.12; workflow path filters now include the probe script.Tests: new
test_packaging.py(stdlib name collisions, bareimport wave, version/name vspyproject.toml) andtest_cleanroom_probe.py(unit coverage for isolation helpers);pyproject.tomladdstomlifor dev on Python < 3.11.Reviewed by Cursor Bugbot for commit 4faf619. Bugbot is set up for automated code reviews on this repo. Configure here.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by Sourcery
Harden Python package validation and clean-room checks to catch broken wheel imports and checkout isolation regressions before publishing.
New Features:
Bug Fixes:
wavepath.scripts/gadirectory tosys.path.Enhancements:
Build:
CI:
Tests:
CodeAnt-AI Description
Prevent Python packaging and clean-room checks from passing when they cannot detect a broken or locally sourced package
What Changed
waveresolves to Python’s standard library, and keep the package version and distribution name aligned with project metadata.Impact
✅ Fewer falsely passing clean-room checks✅ Prevented Python standard-library import collisions✅ Earlier detection of broken wheels before publishing💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.