chore(guard): sync vendored public-repo-guard to canonical - #338
Open
wave-av-release-bot[bot] wants to merge 1 commit into
Open
wave-av-release-bot[bot] wants to merge 1 commit into
wave-av-release-bot[bot] wants to merge 1 commit into
Conversation
|
PR author is in the excluded authors list. |
ApprovabilityVerdict: Needs human review Unable to check for correctness in 5bfeca2. This CI workflow change adds security hardening (persist-credentials: false) which is low-risk, but the changed file is owned by wave-av/streaming-team and the author (release bot) is not a designated owner. The code owners should review this sync. You can customize Macroscope's approvability policy. Learn more. |
🌊 WAVE BugBot — 2 finding(s)🔴 2
severity: critical · major · minor · info — local review · $0 inference · wave-dispatch · react 👍/👎 to tune |
yakimoto
enabled auto-merge
August 15, 2026 14:25
yakimoto
disabled auto-merge
September 12, 2026 16:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs the vendored
public-repo-guardtrio to the canonical source inwave-foundation/scaffolder/public-repo-guard.internal-ipleak rule (Tailscale-CGNAT100.64.0.0/10), lockstep with the pre-publish mirror gateEach changed file is byte-for-byte identical to canonical (verified by git blob SHA). The repo's own
Secrets + content policygate re-scans this PR.🤖 Generated with Claude Code
Summary by cubic
Sync the vendored
public-repo-guardto the canonical config to align security rules and behavior. Setspersist-credentials: falseinactions/checkoutso the job token isn’t available to third‑party scans, matching the canonical guard.Written for commit 5bfeca2. Summary will update on new commits.
Note
Disable credential persistence in
public-repo-guardcheckout stepSets
persist-credentials: falseon theactions/checkoutstep in public-repo-guard.yml, syncing the vendored workflow with the canonical version. Risk: subsequent steps in the workflow will no longer have GitHub credentials injected into the Git config; any Git operations requiring authentication must now supply credentials explicitly.Macroscope summarized 5bfeca2.