Skip to content

Conversation

@alexeykiselev
Copy link
Collaborator

No description provided.

@alexeykiselev alexeykiselev added wip This is a WIP, should not be merged right away do not merge The PR is not ready to be merged labels Dec 19, 2025
@nickeskov nickeskov requested a review from esuwu December 24, 2025 23:38
@nickeskov nickeskov removed the wip This is a WIP, should not be merged right away label Dec 24, 2025
@nickeskov nickeskov requested a review from Copilot December 24, 2025 23:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for the CommitToGenerationTransaction type to Ride library version 9. The CommitToGenerationTransaction is a new transaction type for endorser commitments in the consensus protocol.

Key changes:

  • Adds CommitToGenerationTransaction object with fields for endorser public key, generation period start, commitment signature, and standard transaction fields
  • Extends Ride V9 with support for the new transaction constructor
  • Implements converter from proto transaction to Ride object representation

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
pkg/ride/compiler/stdlib/ride_objects.json Defines the CommitToGenerationTransaction object structure and fields for code generation
pkg/ride/objects.gen.go Generated code for the new transaction type including constructors, equality, getters, and string representation
pkg/ride/constructors.gen.go Generated constructor function for creating CommitToGenerationTransaction instances
pkg/ride/constants.gen.go Adds V9 constants (same as V8)
pkg/ride/functions.gen.go Updates function arrays and maps to include CommitToGenerationTransaction constructor in V9
pkg/ride/converters.go Implements conversion from proto.CommitToGenerationWithProofs to ride object
pkg/ride/selectors.go Updates version selectors to support V9 and refactors error handling
pkg/ride/tree_evaluator.go Removes selectConstantNames function (moved to selectors.go)
pkg/ride/compiler/stdlib/types.go Adds CommitToGenerationTransaction to the V9 Transaction union type
pkg/ride/ride_constructors_test.go Comprehensive test for the new transaction type
pkg/ride/compiler/stdlib/README.md New documentation for Ride code generation process
pkg/ride/compiler.go Adds betteralign tool to generation pipeline
pkg/ride/generate/internal/objects_generation.go Adds betteralign:check comments to generated structs
pkg/ride/generate/internal/constants_generation.go Adds V9 constants generation
pkg/ride/compiler/stdlib/vars.json Adds empty V9 entry

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nickeskov nickeskov force-pushed the add-commit-to-generation-transaction-to-ride-v9 branch from 05aa439 to 79fb18a Compare December 25, 2025 00:03
@alexeykiselev alexeykiselev removed the do not merge The PR is not ready to be merged label Dec 29, 2025
@alexeykiselev alexeykiselev merged commit 7284746 into determenistic-finality-feature Dec 29, 2025
9 checks passed
@alexeykiselev alexeykiselev deleted the add-commit-to-generation-transaction-to-ride-v9 branch December 29, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants