Skip to content

cli: expose harmony and gpt-oss tool parsers#216

Closed
krystophny wants to merge 1 commit into
waybarrios:mainfrom
computor-org:feature/expose-harmony-tool-parser
Closed

cli: expose harmony and gpt-oss tool parsers#216
krystophny wants to merge 1 commit into
waybarrios:mainfrom
computor-org:feature/expose-harmony-tool-parser

Conversation

@krystophny
Copy link
Copy Markdown
Contributor

@krystophny krystophny commented Mar 24, 2026

Summary

  • expose harmony and gpt-oss as valid --tool-call-parser values in vllm-mlx serve
  • factor CLI parser construction so the flag surface is unit-testable
  • add regression coverage for the serve CLI choices

Status

  • refreshed onto current upstream main (b4fa030) on 2026-04-09
  • no logic changes beyond the base refresh

Main files

  • vllm_mlx/cli.py
  • tests/test_server.py

Reviewer focus

This is a CLI-surface fix only. The parser implementations already exist; the gap is that the serve CLI does not currently expose them consistently through --tool-call-parser.

Validation

  • python -m pytest tests/test_server.py -q -> 35 passed, 3 deselected

@krystophny krystophny changed the title Expose Harmony/GPT-OSS tool parser in serve CLI cli: expose harmony and gpt-oss tool parsers Mar 24, 2026
@Thump604
Copy link
Copy Markdown
Collaborator

Thump604 commented Apr 8, 2026

@waybarrios, @krystophny: brief endorsement.

Small CLI-surface fix exposing existing harmony and gpt-oss tool parsers via --tool-call-parser. The parser implementations already exist in the codebase, the gap is just that the serve CLI does not list them as valid choices. The test addition covers the new flag values. Mergeable on current main, low risk.

@krystophny krystophny force-pushed the feature/expose-harmony-tool-parser branch from 16c27bd to f5dc6be Compare April 9, 2026 06:35
@krystophny
Copy link
Copy Markdown
Contributor Author

Force-pushed a refresh onto current upstream main (b4fa030). No logic change beyond the base refresh. Validation: python -m pytest tests/test_server.py -q -> 35 passed, 3 deselected.

@Thump604
Copy link
Copy Markdown
Collaborator

I rebased this onto current main locally and validated it cleanly, but direct maintainer push back to the original fork failed with 403 from this auth context. To keep it moving, I opened a writable restack PR carrying the same functional diff: I’ll link it here as soon as GitHub returns the new PR URL.

@Thump604
Copy link
Copy Markdown
Collaborator

Replacement restack is up at #284: https://github.com/waybarrios/vllm-mlx/pull/284\n\nThat branch carries the same functional diff rebased on current main and passed local validation here:\n- python -m py_compile vllm_mlx/cli.py tests/test_server.py\n- python -m black --check --fast vllm_mlx/cli.py tests/test_server.py\n- pytest -q tests/test_server.py\n\nI could not push directly back to the original fork because GitHub returned 403 for the computor-org remote from this auth context.

@Thump604
Copy link
Copy Markdown
Collaborator

Closing as superseded by #284, which carries the same functional diff on a writable branch and has now been validated on current main. The original fork branch could not be updated from this auth context because GitHub returned 403 on direct push to the computor-org remote.

@Thump604 Thump604 closed this Apr 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants