Skip to content

Undo fallback in abstract_dynamics.py#54

Open
justinjfu wants to merge 1 commit intowaymo-research:mainfrom
justinjfu:dynamics_fix
Open

Undo fallback in abstract_dynamics.py#54
justinjfu wants to merge 1 commit intowaymo-research:mainfrom
justinjfu:dynamics_fix

Conversation

@justinjfu
Copy link
Copy Markdown
Contributor

The fallback trajectory causes bugs with sim agents ignoring collisions and driving with constant velocities as seen in #52. This is because when the sim agent outputs invalid actions, the fallback takes over and controls the agent with constant velocity.

This PR makes the fallback behavior optional and turns it off by default.

@google-cla
Copy link
Copy Markdown

google-cla bot commented Mar 15, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant