Return extra boolean variable "is_binary" from via_content#1
Open
JoshuaS3 wants to merge 2 commits intowbond:masterfrom
Open
Return extra boolean variable "is_binary" from via_content#1JoshuaS3 wants to merge 2 commits intowbond:masterfrom
JoshuaS3 wants to merge 2 commits intowbond:masterfrom
Conversation
Library function via_content will return a second new variable is_binary. `true` if mime type is for binary format, `false` if not. This shouldn't break any old code.
Also uses xpcall to get and report an error message and stack trace of any puremagic library errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this,
via_contentwill return two variables:mimetypeandis_binary.tests.luahas been updated to reflect this change.