feat: OTel instrumentation with strict-privacy telemetry defaults#39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds end-to-end OpenTelemetry instrumentation for Storm API operations and middleware, expands service metrics, and enforces strict-privacy telemetry defaults so sensitive values are not emitted in plaintext.
What Changed
tracing.gohelper (endSpan) to consistently record span errors and close spans.external_calls_total,external_call_duration_seconds).localhost:4318; insecure transport only whenOTEL_EXPORTER_OTLP_INSECURE=true.Privacy/Security Posture
tempo.i.wcyp.rureference was removed.operation failed) instead of raw error strings,RemoteAddr.Validation
Local
go test ./...?cd frontend && npm ci --legacy-peer-deps?cd frontend && npm run lint? (warnings only)cd frontend && npm run test -- --watch=false?src/app/preferences.service.spec.ts:42:7(filterStateimplicitly hasanytype).Notes
.github/workflows/ci.ymlas:Risk & Rollback