Plain-language wording for derived data handling, and document the publish step - #13
Merged
Conversation
Merging a listing does not publish it. The website reads a committed snapshot of this repository, so a page only changes when someone runs the sync, reads the diff, and commits it. That step was undocumented, which is a good way to merge a listing and wonder for a week why it is not live.
The derived `basis` line is the most-read sentence on a community listing, and it was written for the person who built the sandbox: "The addon does not request the network permission, so the Wealthfolio runtime blocks all outbound requests." Every noun in that is ours, not the reader's. Same facts, plainer: "It never asked for internet access, so Wealthfolio will not let it connect to anything." Nothing is softened — the point of the line is that it is a hard statement about what the app does, and it survives being said in short words. Regenerated derived.json; only the basis strings move.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small things and the regenerated output that follows from one of them.
The sentence on every listing page was written for whoever built the sandbox
deriveDataHandlingproduces the line the website shows under "Privacy and permissions". It read:Every noun in that is ours, not the reader's — "network permission", "runtime", "outbound requests". Same fact, plainer:
Nothing is softened. The point of the line is that it is a hard statement about what the app does, and it survives being said in short words. All four branches changed the same way; the test that stops the sandbox claim leaking to unknown-SDK addons was updated to match the new phrasing.
community/derived.json, regeneratedSo the three listings merged today (#5, #6, #9) actually carry it. Only
basisstrings move.CONTRIBUTING.md: how a merged listing reaches the siteMerging a listing publishes nothing. The website builds from a committed snapshot of this repository, so a page only changes when someone runs
pnpm sync:addonsover there, reads the diff, and commits it. That step was undocumented, which is a good way to merge a PR and wonder for a week why it is not live.The website change that renders all of this is a separate PR in
wealthfolio-website. It has to merge after this one, or those three pages ship the old wording.pnpm checkclean.