Repository navigation
fix: reject unknown --format values in validate, lint, and doctor - #42
Merged
owenthcarey merged 1 commit intoAug 31, 2026
Merged
owenthcarey merged 1 commit into
owenthcarey merged 1 commit into
Conversation
Contributor
|
Thanks for a great first contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--formatduring argument parsing forvalidate,lint, anddoctor, so typos fail with the accepted values instead of silently usinghuman output.
Test plan
cargo test --locked --workspaceAdditional checks:
cargo test --locked -p weaveffi-cli --bin weaveffi rejects_unknown_human_json_output_formatscargo test --locked -p weaveffi-clicargo fmt --all --checkcargo clippy --locked -p weaveffi-cli --all-targets --no-deps -- -D warningsNotes for reviewers
extract,format, andschemakeep their existing command-specific formathandling. The full workspace Clippy command was also attempted, but Rust 1.95
reports three pre-existing
collapsible_matchwarnings in unchangedcrates/weaveffi-core/src/validate/rules.rs.