Skip to content

fix: reject unknown --format values in validate, lint, and doctor - #42

Merged
owenthcarey merged 1 commit into
weavefoundry:mainfrom
sjh9714:codex/20260831-37-reject-unknown-format
Aug 31, 2026
Merged

owenthcarey merged 1 commit into
weavefoundry:mainfrom
sjh9714:codex/20260831-37-reject-unknown-format

Conversation

@sjh9714

@sjh9714 sjh9714 commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Summary

Test plan

  • Added or updated tests where appropriate
  • Ran cargo test --locked --workspace
  • Reviewed snapshot results; no snapshot changes were produced
  • Updated user-facing CLI help to list the accepted format values
  • PR title follows Conventional Commits and is under 72 characters

Additional checks:

  • cargo test --locked -p weaveffi-cli --bin weaveffi rejects_unknown_human_json_output_formats
  • cargo test --locked -p weaveffi-cli
  • cargo fmt --all --check
  • cargo clippy --locked -p weaveffi-cli --all-targets --no-deps -- -D warnings

Notes for reviewers

extract, format, and schema keep their existing command-specific format
handling. The full workspace Clippy command was also attempted, but Rust 1.95
reports three pre-existing collapsible_match warnings in unchanged
crates/weaveffi-core/src/validate/rules.rs.

@owenthcarey owenthcarey changed the title fix: reject unknown --format values fix: reject unknown --format values in validate, lint, and doctor Aug 31, 2026
@owenthcarey
owenthcarey merged commit 7b3704d into weavefoundry:main Aug 31, 2026
22 checks passed
@owenthcarey

Copy link
Copy Markdown
Contributor

Thanks for a great first contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reject unknown --format values instead of silently printing human output

2 participants