Repository navigation
fix: publish the facade without its dev-dependencies - #53
Merged
Merged
Conversation
…angelog The facade's dev-dependencies on weaveffi-gen and weaveffi-abi inherited a version from the workspace, so cargo kept them in the published manifest and required weaveffi-gen on crates.io before weaveffi could publish. release-plz publishes the facade first, so the 0.24.0 release stopped there. Path-only dev-dependencies are stripped at publish time. The changelog gets a short header that describes both generators of its entries, and the missing blank line before the 0.23.0 heading.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 0.24.0 release stopped partway: release-plz published
weaveffi-model,weaveffi-abi, andweaveffi-macros, then failed onweaveffiwithno matching package named weaveffi-gen found.Cause
The
weaveffifacade's dev-dependencies onweaveffi-genandweaveffi-abiinherited a version from the workspace. Cargo keeps versioned dev-dependencies in the published manifest, soweaveffican't publish untilweaveffi-genis on crates.io. release-plz publishes the facade first, so it stopped there.Fix
cargo publishstrips. With this change,cargo publish -p weaveffi --dry-runsucceeds against crates.io whileweaveffi-genis still unpublished there.Finishing 0.24.0
weaveffi-gen,weaveffi, andweaveffi-cli0.24.0 still need publishing, andv0.24.0still needs tagging. Merging this PR doesn't do either, becauserelease_always = falsemakes release-plz publish only from release-PR merges.