Open
Conversation
Deprecate WeaviateBackupClient#cancel method, as it is now ambiguous
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent PR added a "cancel restore" operation for backups in Weaviate. This PR provides support for this feature.
At the time we release v6 client canceling restorations was not on the roadmap, so
WeaviateBackupClient's method is calledcancel. With the addition ofcancelRestore,cancelbecomes ambiguous, so it will be deprecated in favor ofcancelCreate.Wrt to testing: it's flaky. With the way Weaviate can only do 1 thing at a time there seems to be some period between getting "restore backup-1" to CANCELLED and being able to start "restore backup-2". While running integration tests locally I kept getting this error.I don't quite know how to work around this reliably.