Skip to content

allow controlling the creation of the cluster api secret #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yuvalgtrustmi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

allow controlling the creation of the cluster api secret #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion weaviate/templates/weaviateSecretClusterAPI.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
{{- if .Values.cluster_api.secret.create }}
apiVersion: v1
kind: Secret
metadata:
name: weaviate-cluster-api-basic-auth
name: {{ .Values.cluster_api.secret.name }}
type: kubernetes.io/basic-auth
data:
{{- ( include "cluster_api.secret" . ) | indent 2 -}}
{{- end }}
4 changes: 2 additions & 2 deletions weaviate/templates/weaviateStatefulset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,12 +84,12 @@ spec:
- name: CLUSTER_BASIC_AUTH_USERNAME
valueFrom:
secretKeyRef:
name: weaviate-cluster-api-basic-auth

@antas-marcin antas-marcin Feb 22, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you set create: false then CLUSTER_BASIC_AUTH_USERNAME and CLUSTER_BASIC_AUTH_PASSWORD are still being added to statefulset and they then point to non-existing secret which may cause errors

@antas-marcin antas-marcin Feb 22, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this check:

.Values.cluster_api.secret.create

needs also to be applied here

@hydaz hydaz Mar 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @antas-marcin,
I also want this feature to be merged. I think with the default value of .Values.cluster_api.secret.create is true, it will not cause any issue. If user want to disable the creation of this secret, they must provide an existing secret. This is an expected behavior I think.

name: {{ .Values.cluster_api.secret.name }}
key: username
- name: CLUSTER_BASIC_AUTH_PASSWORD
valueFrom:
secretKeyRef:
name: weaviate-cluster-api-basic-auth
name: {{ .Values.cluster_api.secret.name }}
key: password
- name: STANDALONE_MODE
value: 'true'
Expand Down
4 changes: 4 additions & 0 deletions weaviate/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1564,3 +1564,7 @@ affinity:
##
priorityClassName: ""
globalPriorityClassName: ""
cluster_api:
secret:
create: true
name: "weaviate-cluster-api-basic-auth"