Fix empty list filter raising IndexError instead of WeaviateInvalidInputError#1942
Open
metawake wants to merge 1 commit intoweaviate:mainfrom
Open
Fix empty list filter raising IndexError instead of WeaviateInvalidInputError#1942metawake wants to merge 1 commit intoweaviate:mainfrom
metawake wants to merge 1 commit intoweaviate:mainfrom
Conversation
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
|
To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge. |
Author
|
I agree with the CLA! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.equal([]),.not_equal([]),.less_than([]),.less_or_equal([]),.greater_than([]),.greater_or_equal([])) caused anIndexError: list index out of rangebecause the code accessedvalue[0]without checking if the list was empty.WeaviateInvalidInputErrorin each affected method, matching the existing pattern used bycontains_any/contains_all/contains_none._FilterToGRPC,_FilterToREST) to preventIndexErrorif an empty list reaches the serialization layer.Closes #933
Files changed
weaviate/collections/classes/filters.py— inline empty-list checks inequal,not_equal,less_than,less_or_equal,greater_than,greater_or_equalweaviate/collections/filters.py— guards in_FilterToGRPClist methods and_FilterToREST.__parse_filtertest/collection/test_filter.py— 6 new unit tests covering each affected filter methodDesign note
The empty-list validation is intentionally inlined in each method rather than extracted into a shared helper, to stay consistent with how
contains_any/contains_all/contains_nonealready handle validation in this codebase.Test plan
pytest test/collection/test_filter.py -v— all 30 tests pass (including 6 new)