Repository navigation
[Gecko Bug 2068066] Return null from *List.item() in Web Speech when the index is out of range. - #62566
Merged
Conversation
…range. item() indexed straight into the array, so an out-of-range index crashed. Blink's item() returns nullptr there and its bindings hand that to JS as null, so make the WebIDL return type nullable and do the same. WebAudio/web-speech-api#212 aligns the spec. Differential Revision: https://phabricator.services.mozilla.com/D324284 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2068066 gecko-commit: 7345f092b989ee703ac09898eb0ae04ee434a111 gecko-commit-git: 15e65f9002f4193a1eff321726ff8983d413f829 gecko-reviewers: media-playback-reviewers, webidl, smaug, alwu
wpt-pr-bot
approved these changes
Sep 9, 2026
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Firefox project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
item() indexed straight into the array, so an out-of-range index crashed.
Blink's item() returns nullptr there and its bindings hand that to JS as
null, so make the WebIDL return type nullable and do the same.
WebAudio/web-speech-api#212 aligns the spec.
Differential Revision: https://phabricator.services.mozilla.com/D324284
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2068066
gecko-commit: 7345f092b989ee703ac09898eb0ae04ee434a111
gecko-commit-git: 15e65f9002f4193a1eff321726ff8983d413f829
gecko-reviewers: media-playback-reviewers, webidl, smaug, alwu