Add rules engine framework and exit code validation#2
Open
milansamuel609 wants to merge 3 commits into
Open
Conversation
Rules Engine Framework: Establishes the core architecture and interfaces to execute diagnostic checks across the environment. Exit Code Validation: Integrates logic within ValidateCommand to map aggregated findings directly to system exit codes.
dsoumis
reviewed
May 29, 2026
dsoumis
reviewed
May 29, 2026
dsoumis
reviewed
May 29, 2026
dsoumis
reviewed
May 29, 2026
dsoumis
reviewed
May 29, 2026
dsoumis
reviewed
May 29, 2026
Author
|
Hi @dsoumis, I have addressed the feedback:
Testing and Verification:
Thank you so much for this guidance; it has been incredibly helpful. I’ve worked on projects on my own before, but I’ve never had this much exposure to how things are done in an industry setting. I’m really looking forward to learning much more from you! :) |
dsoumis
reviewed
May 29, 2026
dsoumis
reviewed
May 29, 2026
dsoumis
reviewed
May 29, 2026
Author
|
Hi @dsoumis, I have addressed all three changes. Please review when you get a chance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Overview:
Introduces the validation data model and exit code verification logic for the JBoss Web Server diagnostics tool pipeline. This forms the foundation for the validation command (Week 1) that evaluates server states and maps results to system exit codes.
Core Structural Additions:
SeverityLevels (Enum): Defines the core diagnostic severities: ERROR, WARN, and INFO.
Finding (Model Class): Root data model defining the attributes required to scan, flag, and display debugging information (e.g., rule ID, category, severityLevels, summary, file, and fix).
ValidateCommand (Logic): Contains the core logic (determineExitCode) to evaluate findings and map them to standard system exit codes.
Architectural Approaches:
Decoupled the validation severity logging from exit code logic, ensuring that a single ERROR severity finding escalates the entire process exit code appropriately.
Structured the Finding model to capture the exact source file and resolution steps immediately to streamline developer troubleshooting.
Testing & Verification:
Test Specifications:
Current Implementation: Created 3 new unit tests in ValidateCommandTest to verify that the determineExitCode logic accurately maps lists of findings (Empty/OK, Warnings-only, and Errors) based on the severityLevel attribute.
Future Scope: While testing currently relies on severityLevels to verify exit codes, the logic can be expanded in future PRs to utilize all Finding model attributes for more precise and accurate evaluation.
Status: All 7 existing framework tests passed, and the 3 newly added validation tests passed successfully.