Skip to content

Remove reference to deprecated CRM.resourceUrls#86

Open
colemanw wants to merge 1 commit into
webaccess:masterfrom
colemanw:resourceUrls
Open

Remove reference to deprecated CRM.resourceUrls#86
colemanw wants to merge 1 commit into
webaccess:masterfrom
colemanw:resourceUrls

Conversation

@colemanw
Copy link
Copy Markdown

@colemanw colemanw commented Mar 26, 2026

Variable is deprecated and soon to be removed.

Instead of downloading the partials via http, this uses the built-in loader from CiviCRM.

See civicrm/civicrm-core#35234

@wacodereviewer
Copy link
Copy Markdown

🤖 WA Code Reviewer Result

PR Overview

This PR is fixing bug 🐛

This pull request removes a reference to a deprecated CRM.resourceUrls variable, which is soon to be removed. The objective is to prevent errors and ensure the code remains stable.


Change Details

Change File List

Modified files:

  • js/simpledonate.js
  • simpledonate.php
Major Changes Description
simpledonate.js This diff contains a change in the configuration of the 'simpledonate' Angular module. The 'when' routes for '/donation/:id/' and '/donation/:id/:thanks' have been updated to use different templateUrls.
simpledonate.php This diff contains an addition to the simpledonate_civicrm_angularModules function. It adds a new key-value pair to the 'simpledonate' array, specifically the 'partials' key with the value ['partials'].

PR Quality Assessment:

Good code quality. The PR meets most standards but has some areas for improvement.

===================== Report End =====================

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants