Remove reference to deprecated CRM.resourceUrls#86
Open
colemanw wants to merge 1 commit into
Open
Conversation
🤖 WA Code Reviewer ResultPR OverviewThis PR is fixing bug 🐛 This pull request removes a reference to a deprecated CRM.resourceUrls variable, which is soon to be removed. The objective is to prevent errors and ensure the code remains stable. Change Details
|
| Major Changes | Description |
|---|---|
| simpledonate.js | This diff contains a change in the configuration of the 'simpledonate' Angular module. The 'when' routes for '/donation/:id/' and '/donation/:id/:thanks' have been updated to use different templateUrls. |
| simpledonate.php | This diff contains an addition to the simpledonate_civicrm_angularModules function. It adds a new key-value pair to the 'simpledonate' array, specifically the 'partials' key with the value ['partials']. |
PR Quality Assessment:
Good code quality. The PR meets most standards but has some areas for improvement.
===================== Report End =====================
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Variable is deprecated and soon to be removed.
Instead of downloading the partials via http, this uses the built-in loader from CiviCRM.
See civicrm/civicrm-core#35234