Reduce point cloud data to positional data - #11
Conversation
|
@soulofmischief is attempting to deploy a commit to the WEBA Team on Vercel. To accomplish this, @soulofmischief needs to request access to the Team. Afterwards, an owner of the Team is required to accept their membership request. If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account. |
| distanceFloats2Canvas, | ||
| depthFloats2Canvas, | ||
| } from '../generators/sg-debug.js'; | ||
| import { getDestructuredPointCloud } from '../lib/index.js'; |
There was a problem hiding this comment.
Not a good name for this... We already have a convention of calling these utils. It's certainly not an index.
There was a problem hiding this comment.
Convention noted, thanks.
There was a problem hiding this comment.
Anything in particular come to mind?
There was a problem hiding this comment.
Is pointCloudDestructureUtil good?
avaer
left a comment
avaer
left a comment
There was a problem hiding this comment.
Needs code cleanup, but makes sense.
| @@ -0,0 +1,40 @@ | |||
|
|
|||
| const pointcloudStride = 4 + 4 + 4 + 1 + 1 + 1; | |||
There was a problem hiding this comment.
I'm pretty sure this constant already exists in the main branch.
|
This is fine, it just needs to have a clear network and non-network point cloud stride constant to make clear what is happening in the code. Both constants (one of which exists) should be put into the After this ships we should change https://github.com/webaverse/AdelaiDepth to do this and then we can get rid of the processing in this repo entirely. |
…street-labs/gen into strip-point-cloud-data
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Looks like this is highly conflicted. |
2 participants
Strip unused point cloud data for a 3MiB savings