Skip to content

Add image compression - #14

Closed
soulofmischief wants to merge 1 commit into
masterfrom
image-compression
Closed

Add image compression#14
soulofmischief wants to merge 1 commit into
masterfrom
image-compression

Conversation

@soulofmischief

Copy link
Copy Markdown
Contributor

Compress images for ~1.8MiB wins using https://www.npmjs.com/package/browser-image-compression

We should fork this package if we're going to use it.

@vercel

vercel Bot commented Dec 18, 2022

Copy link
Copy Markdown

@soulofmischief is attempting to deploy a commit to the WEBA Team on Vercel.

To accomplish this, @soulofmischief needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

@soulofmischief soulofmischief mentioned this pull request Dec 18, 2022
7 tasks
@avaer

avaer commented Dec 18, 2022

Copy link
Copy Markdown
Contributor

Could just use JPEG. Have you compared that?

@soulofmischief

Copy link
Copy Markdown
Contributor Author

Could just use JPEG. Have you compared that?

I haven't, but I figured take the easy gains now and then test quality/size of a few different image types/configurations later. Is that okay for now?

@avaer

avaer commented Dec 20, 2022

Copy link
Copy Markdown
Contributor

I think JPEG would be fine in terms of live artifacts, plus it would load faster.

If we wanted higher quality this seems like a good approach, but IMO speed is more important now.

@soulofmischief

Copy link
Copy Markdown
Contributor Author

Closed for now in favor of #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants