Remove color array - #19
Open
soulofmischief wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
soulofmischief
force-pushed
the
new-remove-color-array
branch
from
December 22, 2022 11:35
c1450b0 to
4c08693
Compare
avaer
approved these changes
Dec 25, 2022
Contributor
|
Needs rebase. |
avaer
suggested changes
Dec 25, 2022
avaer
left a comment
avaer
left a comment
Contributor
There was a problem hiding this comment.
Isn't this still used? https://github.com/webaverse/zine/blob/69396939c542c6fdf29679e8f90a09a1e4792633/zine-renderer.js#L146
Are you sure we don't lose highlighting like this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove color arrays from scene data for a 36MiB savings. This affects the debug shader colors of a few tools, but this functionality can be restored later in a better way.