Track blank-line-before in single-line comments to preserve consecutive grouping#165
Merged
Track blank-line-before in single-line comments to preserve consecutive grouping#165
Conversation
Add `cHadNewlineBefore` field to `InternalComment` to record whether a single-line `//` comment was preceded by a blank line (2+ newlines) in the source. The parser's `separatorParser` now counts total newlines to detect blank lines and stores the result in `ParseState`. The formatter uses this to suppress the extra blank line before a `//` comment when it directly follows another `//` comment with no blank line between them in the source, preserving the original grouping of consecutive comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
cHadNewlineBeforefield toInternalCommentto record whether a single-line//comment was preceded by a blank line (2+ newlines) in the source. The parser'sseparatorParsernow counts total newlines to detect blank lines and stores the result inParseState.The formatter uses this to suppress the extra blank line before a
//comment when it directly follows another//comment with no blank line between them in the source, preserving the original grouping of consecutive comments.