fix(electron): only pass known Electron releases on as wdio:electronVersion - #693
Draft
goosewobbler wants to merge 1 commit into
Draft
goosewobbler wants to merge 1 commit into
goosewobbler wants to merge 1 commit into
Conversation
8 of 14 tasks
Contributor
Release Preview — no release
Updated automatically by ReleaseKit |
…ersion WebdriverIO v10 downloads Chromedriver from the Electron release named in wdio:electronVersion. The launcher copied browserVersion into it, so a Chromium version (as the "Could not determine the Chromium version" error advises) or a fork build reached it too, and WebdriverIO would fetch a release that doesn't exist. - Set wdio:electronVersion only when the Electron -> Chromium map knows the version. Everything else keeps to the browserVersion path, which WebdriverIO v9 uses anyway. - Read an existing wdio:electronVersion first, so a set value wins and a second conversion doesn't read the Chromium browserVersion as the Electron version. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
goosewobbler
force-pushed
the
fix/electron-version-capability
branch
from
October 1, 2026 13:49
c682f1c to
e547801
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
WebdriverIO v10 will download Chromedriver from the Electron release named in
wdio:electronVersion(goosewobbler/webdriverio#10, not yet upstream). v9 ignores the capability and keeps usingbrowserVersion.The launcher copied
browserVersionintowdio:electronVersion. WhenbrowserVersionheld a Chromium version, as the "Could not determine the Chromium version for Electron" error advises, or a fork build such as castlabs+wvcus, WebdriverIO v10 would try to download an Electron release that doesn't exist. For a Chromium version, puppeteer's Chrome for Testing fallback then installs a driver at a path the Electron layout doesn't expect, and the cache stays broken for that build.This change:
wdio:electronVersiononly for a known release. It must be a version the Electron → Chromium map knows. Anything else keeps to thebrowserVersionpath, which is what v9 uses anyway.wdio:electronVersionfirst. A value set in the config wins, and a second conversion no longer reads the ChromiumbrowserVersionas the Electron version.wdio:electronVersion.browserVersionhandling is unchanged, so WebdriverIO v9 behaves exactly as before.Related Issues
Pairs with the WebdriverIO v10 Electron-release Chromedriver work. WebdriverIO no longer guesses whether
wdio:electronVersionholds a Chromium version, so the service mustn't put one there.Type of Change
Scope
scope:electron- Electron service and CDP bridgescope:tauri- Tauri service and pluginChecklist
pnpm lint)pnpm test)pnpm typecheck)Testing
browserVersionand one for an existingwdio:electronVersion. Two existing tests now expect an unmapped version to stay out ofwdio:electronVersion. All four fail without the change.@wdio/electron-service: 555 tests pass, and typecheck, Biome and ESLint are clean.Additional Context
wdio:electronVersion, so for a fork build they now skip the informational Electron-version line.launcher.ts) and the hard "Could not determine the Chromium version" error can relax. Both exist because Chrome for Testing has no Chromedriver before 115.0.5763.0, and the Electron release ships its own driver.wdio sessioncan pass the Electron version aswdio:electronVersioninstead ofbrowserVersion.Note: This repository does not backport changes to older versions. All changes target the current
mainbranch.🤖 Generated with Claude Code