Skip to content

ci(release): take the release notes model from the OLLAMA_MODEL variable - #780

Merged
goosewobbler merged 2 commits into
mainfrom
ci/ollama-model-variable
Oct 24, 2026
Merged

goosewobbler merged 2 commits into
mainfrom
ci/ollama-model-variable

Conversation

@goosewobbler

@goosewobbler goosewobbler commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

The release notes model now comes from the OLLAMA_MODEL repository variable, so it can be switched in the repository settings without a PR.

Until now, releasekit.config.json hardcoded minimax-m2.7:cloud, and the OLLAMA_MODEL variable did nothing. releasekit stopped reading it when goosewobbler/releasekit#564 made an explicit llm.model mandatory, and no workflow passed it in. That's why the tauri 1.5.1 release still used minimax-m2.7.

Changes

  • releasekit.config.json: "model": "{env:OLLAMA_MODEL}". releasekit substitutes {env:NAME} when it loads the config.
  • Every releasekit step passes OLLAMA_MODEL: ${{ vars.OLLAMA_MODEL }}. releasekit validates the whole config on every run, so a step without it fails at config load, even if it never calls the model. The steps:
    • _release.reusable.yml: the scoped release, the standing-PR publish, and the refresh after a release;
    • _standing-pr-update.reusable.yml;
    • release.yml's gate.
  • release-preview.yml uses a placeholder instead. The preview runs on every PR, including PRs from forks, and repository variables aren't passed to fork PR runs (community discussion #44322, still open), so vars.OLLAMA_MODEL would be empty there. The preview skips release notes (skipNotes: true in releasekit's preview), so the model only has to pass validation. config: name unset {env:} variables in validation errors, and require llm.model only when notes run goosewobbler/releasekit#811 asks releasekit to require llm.model only when a run produces notes, after which the placeholder can go.
  • .github/workflows/README.md documents the variable, and that a local releasekit run needs it exported.

Verification

  • releasekit release --dry-run --skip-notes with releasekit 0.42.1 (scoped to @wdio/native-spy):
    • With OLLAMA_MODEL set: the config loads and the run succeeds.
    • Without it: the run fails with CONFIG_ERROR: notes.releaseNotes: Invalid input.
  • actionlint passes.
  • release.yml, _release.reusable.yml and _standing-pr-update.reusable.yml count as core CI infrastructure, so this PR runs the full CI matrix.

Notes

  • The OLLAMA_MODEL variable is already set to minimax-m3.1-flash:cloud, which Ollama's cloud lists.
  • The OLLAMA_BASE_URL repository variable is still unused, because the config sets baseURL.

🤖 Generated with Claude Code

releasekit.config.json hardcoded minimax-m2.7:cloud. The OLLAMA_MODEL
repository variable did nothing: releasekit stopped reading it when
releasekit#564 made an explicit llm.model mandatory, and no workflow passed
it. The config now reads `{env:OLLAMA_MODEL}`, so the model can be switched
in the repository settings.

releasekit validates the whole config on every run, so every step that runs
it passes the variable. The release preview gets a placeholder instead: it
skips release notes, and repository variables aren't passed to pull
requests from forks, so vars.OLLAMA_MODEL would be empty there.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

Release notes now use the OLLAMA_MODEL repository variable instead of a hardcoded model.

  • Release notes use the model chosen in repository settings.

Since the previous review, only the preview comment wording changed. No new actionable issues were found. No previous review threads were supplied.

Reviews (2) · Last reviewed commit: "ci(release): explain the preview's model..." · Reviewed by Greptile

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@goosewobbler
goosewobbler merged commit 6de4e1c into main Oct 24, 2026
13 checks passed
@goosewobbler
goosewobbler deleted the ci/ollama-model-variable branch October 24, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant