Repository navigation
ci(release): take the release notes model from the OLLAMA_MODEL variable - #780
Merged
Merged
Conversation
releasekit.config.json hardcoded minimax-m2.7:cloud. The OLLAMA_MODEL
repository variable did nothing: releasekit stopped reading it when
releasekit#564 made an explicit llm.model mandatory, and no workflow passed
it. The config now reads `{env:OLLAMA_MODEL}`, so the model can be switched
in the repository settings.
releasekit validates the whole config on every run, so every step that runs
it passes the variable. The release preview gets a placeholder instead: it
skips release notes, and repository variables aren't passed to pull
requests from forks, so vars.OLLAMA_MODEL would be empty there.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
[Medium impact] The PR appears safe to merge.
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release notes model now comes from the
OLLAMA_MODELrepository variable, so it can be switched in the repository settings without a PR.Until now,
releasekit.config.jsonhardcodedminimax-m2.7:cloud, and theOLLAMA_MODELvariable did nothing. releasekit stopped reading it when goosewobbler/releasekit#564 made an explicitllm.modelmandatory, and no workflow passed it in. That's why the tauri 1.5.1 release still used minimax-m2.7.Changes
releasekit.config.json:"model": "{env:OLLAMA_MODEL}". releasekit substitutes{env:NAME}when it loads the config.OLLAMA_MODEL: ${{ vars.OLLAMA_MODEL }}. releasekit validates the whole config on every run, so a step without it fails at config load, even if it never calls the model. The steps:_release.reusable.yml: the scoped release, the standing-PR publish, and the refresh after a release;_standing-pr-update.reusable.yml;release.yml's gate.release-preview.ymluses a placeholder instead. The preview runs on every PR, including PRs from forks, and repository variables aren't passed to fork PR runs (community discussion #44322, still open), sovars.OLLAMA_MODELwould be empty there. The preview skips release notes (skipNotes: truein releasekit's preview), so the model only has to pass validation. config: name unset {env:} variables in validation errors, and require llm.model only when notes run goosewobbler/releasekit#811 asks releasekit to requirellm.modelonly when a run produces notes, after which the placeholder can go..github/workflows/README.mddocuments the variable, and that a local releasekit run needs it exported.Verification
releasekit release --dry-run --skip-noteswith releasekit 0.42.1 (scoped to@wdio/native-spy):OLLAMA_MODELset: the config loads and the run succeeds.CONFIG_ERROR: notes.releaseNotes: Invalid input.release.yml,_release.reusable.ymland_standing-pr-update.reusable.ymlcount as core CI infrastructure, so this PR runs the full CI matrix.Notes
OLLAMA_MODELvariable is already set tominimax-m3.1-flash:cloud, which Ollama's cloud lists.OLLAMA_BASE_URLrepository variable is still unused, because the config setsbaseURL.🤖 Generated with Claude Code