Repository navigation
ci: let a v9 publish survive a Rekor 409 and finish a publish that failed part-way (v9) - #16348
Merged
Merged
Conversation
…iled part-way (v9)
plum117
marked this pull request as ready for review
November 3, 2026 00:14
Contributor
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryAdds a recovery option for partially published v9 releases and patches
Diagram%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Install and build] --> B[Patch Lerna and sigstore]
B --> C{Release type}
C -->|from-package| D[Publish versions missing from npm]
C -->|Version bump| E[Run normal Lerna release]
E --> F[Push release tag]
Reviews (1) · Last reviewed commit: "ci: let a v9 publish survive a Rekor 409..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The 9.33.0 and 9.33.1 publish runs (41533530853, 41549118680) stopped part-way with:
sigstore4.1.1 (lerna 9.0.7 →libnpmpublish11.1.2) gives each Rekor upload 5 s with 2 retries, and lerna passes no timeout. When Rekor saves the first upload but answers after 5 s, the retry gets a 409, andfetchOnConflict: falsefails the package. 9.33.0: 1 package failed (27/38 published), 9.33.1: 6 failed (30/38). Rekor saved each failed entry 2-9 s before the error.releaseType: from-package: publishes only the versions that are not on npm; no version step, changelog, GitHub release or tag@wdio/lerna-patchalso patchessigstore'sconfig.js(fetchOnConflict: true). It throws, before anything is published, if the code changed.node_modules/lernais a pnpm link).How you tested
sigstore4.1.1 of the lockfile: the 1st upload is saved but answers after 6 s, the retry gets 409.TLOG_CREATE_ENTRY_ERROR … (409) an equivalent entry already exists …(the CI error).GET /api/v1/log/entries/<uuid>, the entry is returned.pnpm -r --filter=@wdio/lerna-patch run patchtwice:Code patched, thenCode already patched.releaseTypeoptions:patch, minor, major, premajor, from-package. eslint passes.Types of changes
Checklist
Backport Request
v9and doesn't need to be back-ported#XXXXXFurther comments
mainhas the same sigstore code (follow-up).Reviewers: @webdriverio/project-committers