merge all parser entrypoints to avoid codegen duplication. See lalrpop#65#211
Merged
Conversation
k2d222
force-pushed
the
parser-single-entrypoint
branch
from
5eef5b3 to
e57d685
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wgsl-parsetook 25s to compile. The parser was running 7 times and generating 7x as much code. This is caused by a bug in the parser generator (lalrpop/lalrpop#65) which regenerates a full parser for each entry point (expressions, statements...) even if they share production rules.In a subsequent PR, I'll reduce compile times further by including the generated parser code in the source instead of invoking lalrpop in build.rs. This should reduce compile times a lot more.