client side builtin_shadow diagnostic#188
Draft
mighdoll wants to merge 1 commit into
Draft
Conversation
This reverts commit eb455ad.
Merged
Collaborator
|
Are there other cases where we should warn when a builtin in shadowed? For example |
k2d222
reviewed
Jul 1, 2026
| is intentional. | ||
| - **`builtin_shadow`** fires on a wildcard import when a referenced name in the | ||
| module resolves to a wildcard-imported item that shadows a WGSL builtin such | ||
| as `vec3` or `clamp`. Suppress at the import site if the override is |
Contributor
There was a problem hiding this comment.
just import site or both declaration site and import site? I understood it's both from a sentence above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
builtin_shadow diagnostic warns clients if they're wildcard overriding a builtin (supressible)