Repository navigation
fix(ui): Move NavBar to dedicated component folder and make it sticky - #194
moshams272 wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Seems fine to me, just note that this Navbar wasn't designed to be sticky, iirc, cc @ovflowd |
bjohansebas
left a comment
There was a problem hiding this comment.
Hmm, it feels a bit strange to me now that it's sticky. I personally prefer when websites don't implement sticky navbar, but that's just my opinion. If you all think it should be sticky, then go for it.
What about Hide/Show on Scroll Navbar?! |
|
@avivkeller I saw this was closed, was this done somewhere else? |
|
My understanding was that for parity with doc-kit, we didn't want a sticky navbar |
Summary
This PR makes the NavBar component sticky in top.