This repository was archived by the owner on Sep 22, 2023. It is now read-only.
refactor the library to use streams#24
Open
jewell-lgtm wants to merge 1 commit intowebschik:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The promised based API was actually a blocking API in disguise, and we have had some performance issues using this library in production on some larger mt940 files.
This PR removes the Promise API and replaces it with a streams based API, which allows us to process a statement at a time. The previously Promised based api is now synchronous, as the parser would block the event loop anyway, and in my performance tests this was actually quicker.
I'd be happy to hear your feedback on this, and thanks for all the great work that has gone into v1.0.0 of this library!