Open
Conversation
Moved load handler inside the class
Member
|
Thank you 👍 |
Contributor
|
Thanks for the PR! I'll get to rebasing/reviewing this in a bit. However, I have to comment that unfortunately any public facing API changes require a review from a core maintainer; I understand it's been quite a while since this PR was made, but I'll try to flag someone down to get this reviewed and and merged once I've gotten it updated. Thanks for your patience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds setContextMenuEnabled to the webui object for users to be able to turn it on and off. I think the best reason to allow a user to use a 3rd party context menu like: https://github.com/fkhadra/react-contexify
A few other minor things:
*) Used passive event binding for situations where we don't modify the event object
*) Moved the context menu bind off body to the document itself. Otherwise you can right click on the lower part of the window with shorter pages.
*) To avoid duplicating code I moved the load handler inside the main class. There may be some specific reason it wasn't, but I didn't see what it was.