Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a CI workflow that runs quality checks on every pull request and on
every push to
main. The repository previously had no PR-time enforcementof tests, linting, or
go modhygiene — quality was only enforced vialocal
pre-commithooks, which contributors without the hooks installed(and Dependabot bumps) would bypass entirely. This change closes that gap
with a hand-rolled GitHub Actions workflow that mirrors the local
pre-commit gates one-to-one.
Modifications
.github/workflows/qa-checks.yml(new) — surfaces as the QA Checks status onPRs. Triggers on
pull_requestandpushtomain. Two jobs:go— runs onubuntu-latest, usesgo-version-file: go.modso the Go versionalways matches the module declaration. Steps:
go mod tidyfollowed by agit diff --exit-codecheck ongo.mod/go.sum, soout-of-date module files fail the PR with a clear error pointing at the fix.
go vet ./...go test -race ./...(the-raceflag catches data races that the default testrunner misses).
golangci-lintviagolangci/golangci-lint-action@v6, pinned to v2.2.2 tomatch
.pre-commit-config.yamlexactly — so local and CI lint results agree.docs— runs onubuntu-latestinsidedocs/. Uses pnpm 11 with the Nuxt-awareESLint flow:
pnpm install --frozen-lockfilepnpm exec nuxt prepare(regenerates.nuxt/eslint.config.mjs, which the project'sESLint config imports — matches the workaround documented in
.pre-commit-config.yaml).pnpm lint(runseslint .).contents: readonly — minimum needed and followsleast-privilege defaults.