Open
Conversation
Remove the two newlines added as part of the #PERSONAL-SALUTATION# keyword substitution as they lead to unexpected additional line breaks
Contributor
|
hmmm yes. But it fix could break existing actions. We need a database migration to add the removed newlines in the database. |
mcnilz
pushed a commit
that referenced
this pull request
Mar 24, 2020
- remove sentry - remove password-compat - update dompdf - update swiftmailer (update your factories.yml !) - update htmlpurifier - update php-markdown - update paypal sdk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the two newlines added as part of the #PERSONAL-SALUTATION# keyword substitution as they lead to unexpected additional line breaks.
For example, I might have the following in the email template:
Which I expect to get replaced by
Instead, it currently gets replaced by
Which means that in order to get a correct result, I currently have to write the following email template, which looks confusing to the user: