Fix HighMemoryUsage alert: Use machine_memory_bytes and add self-dividing PromQL check#7
Open
Samarth1306w wants to merge 1 commit into
Open
Fix HighMemoryUsage alert: Use machine_memory_bytes and add self-dividing PromQL check#7Samarth1306w wants to merge 1 commit into
Samarth1306w wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed the
HighMemoryUsagePrometheus alert rule intools/monitoring_setup.pyby replacing the self-dividing expression with a valid ratio comparing process resident memory against total machine memory. Also implemented offline alert rule validation to prevent self-dividing expressions.Changes
HighMemoryUsagealert rule expression fromprocess_resident_memory_bytes / process_resident_memory_bytestoprocess_resident_memory_bytes / machine_memory_bytes.validate_alert_expressionsintools/monitoring_setup.pywhich uses regular expressions to detect self-dividing identifiers.tools/test_monitoring.pyvalidating the checker function and verifying that all recommended alert rules pass.build.pyto supportandroidmapping for local builds.diagnostic/build-2b54872c.jsonand.logd.Testing
Checklist
/claim #1