fix HighMemoryUsage alert ratio expression#8
Open
GautamKumarOffical wants to merge 1 commit into
Open
Conversation
Signed-off-by: Gautam Kumar <gautamkumarofficial@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the HighMemoryUsage alert expression in
tools/monitoring_setup.py.Problem
The original expression
process_resident_memory_bytes / process_resident_memory_bytes > 0.9divides a metric by itself, which always evaluates to 1.0 (or causes division by zero). This means the alert never fires correctly.Solution
process_resident_memory_bytes / machine_memory_bytes > 0.9which correctly compares process memory against total available machine memoryvalidate_alert_expr()function that detects self-dividing expressions using regex, preventing similar bugs in the futureupload_prometheus_rules()to skip invalid alert rules with a warningChanges
tools/monitoring_setup.py: Fixed alert expression and added validationDiagnostic
Included encrypted diagnostic log (
diagnostic/build-2b54872c.logd) from build run (password:3a09b1a2e90c3fd3bdb7).