Skip to content

treebuilder: fix file resource leaks#1511

Merged
bcl merged 1 commit into
weldr:masterfrom
yueyuankun:master
Mar 24, 2026
Merged

treebuilder: fix file resource leaks#1511
bcl merged 1 commit into
weldr:masterfrom
yueyuankun:master

Conversation

@yueyuankun

@yueyuankun yueyuankun commented Mar 24, 2026

Copy link
Copy Markdown
  1. File resource leak risk : Fixed file handling issues in the generate_module_info() function
  2. Code quality improvement : Used context managers to ensure proper file closure

Signed-off-by: yueyuankun <yueyuankun@kylinos.cn>
@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 23483124560

Details

  • 0 of 6 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 41.561%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/pylorax/treebuilder.py 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
src/pylorax/treebuilder.py 1 40.2%
Totals Coverage Status
Change from base Build 22962972632: -0.04%
Covered Lines: 1643
Relevant Lines: 3914

💛 - Coveralls

@bcl bcl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@bcl bcl merged commit dc3b14a into weldr:master Mar 24, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants