Added render class for Viewfield.#4
Conversation
Absorbed the following functions into the class: - viewfield_element_info() - viewfield_pre_render() - viewfield_post_render() - _viewfield_get_view_args() -- This was made getViewArgs() which is a protected method Left rendering for the theme.
… the arguments from the path.
* adding-cache-tags: Using buildRenderable() to add cache metadata Remove kint() Adding cache tags # Conflicts: # viewfield.module
This is so that the arguments have had an opportunity to get aggregated by the Viewfield class.
|
I combined the changes from: |
derhasi
left a comment
derhasi
left a comment
There was a problem hiding this comment.
@marcus-n3rd, thanks for your work. I'm just starting getting into the issues again after some months.
Here are some issues I found from a "meta" perspective. I will have a closer look at the functionality itself later.
| * Contains \Drupal\Core\Render\Element\Viewfield. | ||
| */ | ||
|
|
||
| namespace Drupal\Core\Render\Element; |
There was a problem hiding this comment.
It should not use core's namespace, but Drupal\viewfield\... instead.
| */ | ||
| class Viewfield extends RenderElement { | ||
|
|
||
| public function getInfo() { |
There was a problem hiding this comment.
This needs at least function documentation. I guess {@inheritdoc} should do its job here.
| ); | ||
| } | ||
|
|
||
| public static function preRenderViewfield($element) { |
There was a problem hiding this comment.
This needs some proper function documentation and type declaration.
| return $element; | ||
| } | ||
|
|
||
| public static function postRenderViewfield($content, $element) { |
There was a problem hiding this comment.
This needs some proper function documentation and type declaration too.
| /** | ||
| * Perform argument replacement | ||
| */ | ||
| protected function getViewArgs($vargs, $entity_type, $entity) { |
There was a problem hiding this comment.
There needs to be some parameter documentation.
|
Oh fudge. While step debugging through in order to double check the argument types, I found that none of Viewfield class is actually used. 🤦 I'm going to run through and see if there are parts that can be consumed and used in the other classes. |
|
I am really pondering the value of having it as a RenderElement. Could the functionality just be moved into the ViewfieldDefaultFormatter (with the theme name changing to simply |
|
Well, I was trying to fix the caching issues and added that in the field formatter. As Berdir suggested, we should move that somewhere else where the render array is being built and that is what you approach does, right? |
|
Closing in preference of #8. |
4 participants
Absorbed the following functions into the class:
-- This was made getViewArgs() which is a protected method
Left rendering for the theme, i.e.: removed
$output = render ($view_el);, other than that I didn't touch any logic within the functions.Thank Metal Toad for paying my hours for this. Lightly tested this on a client's project and I'd say it's now eligible to go from sandbox to full project status.