Open
Conversation
cyfung1031
added a commit
to cyfung1031/ajax-hook
that referenced
this pull request
Aug 16, 2023
cyfung1031
added a commit
to cyfung1031/ajax-hook
that referenced
this pull request
Aug 16, 2023
cyfung1031
added a commit
to cyfung1031/ajax-hook
that referenced
this pull request
Aug 16, 2023
cyfung1031
added a commit
to cyfung1031/ajax-hook
that referenced
this pull request
Aug 16, 2023
cyfung1031
added a commit
to cyfung1031/ajax-hook
that referenced
this pull request
Aug 16, 2023
Contributor
Author
|
Combined Distribution Script |
Collaborator
|
这次改动是要解决丢失 removeListener 的问题? |
Contributor
Author
之前只做了addEventListener,addEventListener跟removeEventListener是一對的 雖然很少機會會用removeEventListener,但你猜不到原本網站其他的XHR處理是怎樣,不理的話有機會報錯 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getEventTarget(xhr)document.createElement('a')was used.document.createDocumentFragment()would be a better way to create EventTarget since the creation of HTMLElement is slightly higher thanDocumentFragmentdocument.createDocumentFragment()is well supported in ES5. (just Opera 10-12 is unknown)addEventListener and removeEventListener
removeEventListenerwas missing, but mentioned inindex.d.tsWeakMapis used for this particular usage.WeakMapin very old browsers might be not supported, in that case,removeEventListeneris ignored.Minor fix in event handler
changedthe type must be the same as theevent.type = args[0];toevent.type = e.type;to avoid memory leakage of arrayargs.args[0]. assignment not required.