Feat/storybook migration#3
Merged
Merged
Conversation
zamderax
commented
Sep 1, 2025
zamderax
commented
Contributor
- Added a custom pivot control system
- Removed ladle for storybook
- Add Storybook dependencies and configuration - Migrate all stories from Ladle to Storybook format - Update package.json scripts for Storybook - Update GitHub workflow to build and deploy Storybook - Update README with Storybook development instructions - Remove all Ladle configuration files
- Fix missing default exports in all story files - Correct react-map-gl import resolution in Vite config - Add proper Meta and StoryObj types to all stories
- Prefix Mapbox examples with 'Mapbox Examples/' - Prefix MapLibre examples with 'MapLibre Examples/' - Ensures unique story IDs across all story collections
- Point aliases to actual index files (maplibre.index.ts, mapbox.index.ts) - Fixes EISDIR errors when Vite tries to read directories as files
- Remove useLadleContext and ThemeState imports - Replace dynamic theme selection with default themes - Fix runtime error 'Cannot read properties of undefined (reading globalState)'
- Move all R3F hooks and components into SceneContent component - Ensures hooks are only used within Canvas component context - Fixes 'Hooks can only be used within the Canvas component' error
- Disable EffectComposer and Bloom components to avoid R3F hooks error - react-three-map Canvas has compatibility issues with @react-three/postprocessing - Story now renders without errors, post-processing can be re-enabled once compatibility is resolved
- Remove redundant DefaultStory, DefaultStory exports - Storybook automatically creates stories from component in meta - Fixes duplicate story entries in sidebar
- Import Canvas from correct path (react-three-map/mapbox) in StoryMapbox - Add Mapbox token configuration to Storybook - Define VITE_MAPBOX_TOKEN environment variable in Vite config - Fixes 'Cannot read properties of undefined (reading getMap)' error
- Use loadEnv from Vite to properly load .env variables - Set default token in components if env variable not found - Remove redundant .storybook/.env file - Ensure token is set before map initialization
- Introduced .env.example for Mapbox API token configuration - Updated .npmignore to exclude .storybook instead of .ladle - Changed package manager from Yarn to npm in package.json and workflows - Updated README to reflect npm usage for installation and scripts - Refactored StoryMap component to support both Mapbox and MapLibre - Removed legacy Ladle dependencies and configurations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.