Skip to content

TUI: inherit terminal background colors#258

Merged
wesm merged 2 commits intomainfrom
feat/feedback
Apr 11, 2026
Merged

TUI: inherit terminal background colors#258
wesm merged 2 commits intomainfrom
feat/feedback

Conversation

@wesm
Copy link
Copy Markdown
Owner

@wesm wesm commented Apr 10, 2026

Summary

  • Remove forced #ffffff/#000000 backgrounds from TUI styles so the interface respects the user's terminal color scheme
  • Cursor row, title bar, alt rows, and search highlight retain explicit backgrounds for contrast

Addresses user feedback that the TUI clashes with non-default terminal themes.

🤖 Generated with Claude Code

Remove explicit bgBase backgrounds from most styles so the TUI
respects the user's terminal color scheme. Only cursor, title bar,
alt rows, and highlight keep explicit backgrounds for contrast.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@roborev-ci
Copy link
Copy Markdown

roborev-ci bot commented Apr 10, 2026

roborev: Combined Review (6d8ea06)

Verdict: Changes are mostly sound, but there is one medium-severity rendering regression to address before merge.

Medium

  • internal/tui/view.go:69, internal/tui/view.go:1422, internal/tui/view.go:1457
    Removing the modal background introduces a rendering regression in overlayModal(). The modal is assembled by splicing ANSI-styled background fragments with truncateToWidth() and skipToWidth(), so if the left fragment ends while a background color is still active (for example from cursorRowStyle or altRowStyle), the unstyled modal content can inherit that background. This causes the modal body and padding to render inconsistently instead of using the terminal default background.
    Suggested fix: keep an explicit background on modalStyle, or explicitly reset/apply the intended background before writing each modalLine into the composed output.

Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

The overlay compositor splices background row fragments around
modal lines. Without an explicit modal background, active ANSI
color sequences from cursor/alt rows leak into modal content.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@roborev-ci
Copy link
Copy Markdown

roborev-ci bot commented Apr 10, 2026

roborev: Combined Review (25b684c)

Verdict: No medium-or-higher issues found.

All reviewed agents agree this PR is clean at Medium, High, and Critical severity.

Briefly: the diff is limited to TUI background/styling behavior in internal/tui/view.go, with explicit backgrounds retained where needed for contrast and modal compositing, and no security-relevant regressions were identified.


Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

@wesm wesm merged commit ea5699c into main Apr 11, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant