fix: correct Google Sheets credential import path#64
Open
FelixNg1022 wants to merge 2 commits into
Open
Conversation
Import defineOAuth2Credential from '@jam-nodes/core' instead of the non-existent '../types/credentials.js' path, matching the pattern used by other integrations (slack, social). Closes wespreadjam#61
There was a problem hiding this comment.
Pull request overview
This PR fixes a runtime ERR_MODULE_NOT_FOUND in the Google Sheets integration by updating the defineOAuth2Credential import to use the public @jam-nodes/core entrypoint, consistent with other integrations.
Changes:
- Replace non-existent relative import (
../types/credentials.js) with@jam-nodes/corein Google Sheets credential definition.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Tests cover: - Credential definition imports correctly (the root cause of wespreadjam#61) - Credential OAuth2 config and schema validation - Node metadata for all 4 Google Sheets nodes - Schema validation for all input schemas - Executor credential guard (returns error without credentials)
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ERR_MODULE_NOT_FOUNDcaused by importingdefineOAuth2Credentialfrom non-existent../types/credentials.js@jam-nodes/core, matching the pattern used by slack and social integrationsCloses #61
Test plan
pnpm build— verify no module resolution errorsnode packages/playground/dist/index.js run end --mock --input '{"message":"done"}'— no ERR_MODULE_NOT_FOUND