feat: Apollo extended operations — enrich person, enrich company, email status (#17)#79
Open
jackulau wants to merge 1 commit into
Open
feat: Apollo extended operations — enrich person, enrich company, email status (#17)#79jackulau wants to merge 1 commit into
jackulau wants to merge 1 commit into
Conversation
Extends the Apollo integration per issue wespreadjam#17. New operations: - apolloEnrichPersonNode — POST /api/v1/people/match by email - apolloEnrichCompanyNode — GET /api/v1/organizations/enrich by domain - apolloGetEmailStatusNode — reuses people/match to derive a normalized valid/invalid/unknown verdict via the mapApolloEmailStatus helper Also adds apolloCredential built with defineApiKeyCredential (X-Api-Key header) and wires the new nodes + credential through every barrel (apollo, integrations, top-level src/index.ts) including the builtInNodes array. Fixes an unrelated pre-existing bug in google-sheets/googleSheets.ts that was importing defineOAuth2Credential from a non-existent '../types/credentials.js' path — corrected to '@jam-nodes/core'. Without this fix, anything that loads packages/nodes/src/index.ts (including the new apollo integration test that asserts builtInNodes contains the new nodes) fails to resolve modules. 39 new unit tests cover: credential metadata, schema validation, success paths, null/missing-field handling, 4xx/5xx responses, network errors, and the full status mapping matrix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #17. Extends the Apollo integration with a formal credential definition and three new operations.
apolloCredential— built withdefineApiKeyCredential(X-Api-Keyheader), matchesdevtoCredential/apifyCredentialshape.apolloEnrichPersonNode—POST /api/v1/people/matchby email, returns a typed person projection.apolloEnrichCompanyNode—GET /api/v1/organizations/enrichby domain, returns a typed organization projection.apolloGetEmailStatusNode— reusespeople/matchand normalizesemail_statusvia an exportedmapApolloEmailStatushelper tovalid/invalid/unknown.Wired through
apollo/index.ts,integrations/index.ts, and the top-levelbuiltInNodesarray inpackages/nodes/src/index.ts.Also fixes a pre-existing import in
google-sheets/googleSheets.tsthat was pullingdefineOAuth2Credentialfrom a non-existent'../types/credentials.js'path — corrected to'@jam-nodes/core'. Without this, anything loadingpackages/nodes/src/index.ts(including the new Apollo tests) fails module resolution.Test plan
npx vitest run src/integrations/apollo— 39/39 passmain(Zod v4 drift intransform/sort.ts, SlackNodeCredentials.slackmissing) are unchanged by this PR