Skip to content

chore(evm): bump the pinned evm2 revision #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jxom merged 1 commit into from
Aug 6, 2026
+18 −16
Merged

chore(evm): bump the pinned evm2 revision #380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/wasm/internal/evm2.wasm.ts
View file
Open in desktop

Large diffs are not rendered by default.

14 changes: 8 additions & 6 deletions wasm/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,7 @@ the ABI version, the import list, and the reproducibility check unverifiable.
Building your own means owning the artifact:

1. Copy `wasm/evm2` and keep `Cargo.lock` and `rust-toolchain.toml` as they are.
The pinned toolchain is load-bearing, and a nightly compiler selects an
interpreter backend wasm cannot use.
The pinned toolchain is what makes the artifact reproducible.
2. Add the configuration where the engine is constructed in `src/lib.rs`. Keep
`abi.rs` and the ABI version untouched if `src/evm/internal/codec.ts` is to
keep reading the responses.
Expand All @@ -187,10 +186,13 @@ general change, not maintained as a patched fork.
lockfile, and the source. `wasm-opt` is host-stable and still runs natively.
`OX_EVM2_NATIVE=1` builds on the host for fast local iteration; `wasm:check`
refuses it, the same way it refuses `OX_WASM_CLANG`.
- **The toolchain is pinned as stable, deliberately.** evm2 selects a tail-call
interpreter backend when it detects a nightly compiler, which needs unstable
features WebAssembly cannot use. Stable resolves to `single_return`, the
backend evm2 intends for wasm.
- **The toolchain is pinned for reproducibility.** The artifact is a function of
the image, the lockfile, and the source, so the compiler version is part of the
contract. It was also once a correctness requirement: evm2 selected its
tail-call interpreter backend from the toolchain before the target, so a
nightly wasm build picked a backend needing unstable features. Fixed upstream
in [#345](https://github.com/alloy-rs/evm2/pull/345), which the pinned revision
now carries, so the pin is about reproducibility alone.
Comment on lines +193 to +195

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update the remaining stable-toolchain guidance

This paragraph now says #345 removed the nightly-WASM restriction, but wasm/evm2/rust-toolchain.toml:1-3 and AGENTS.md:141 still state that stable Rust is required because nightly selects an unusable backend. Maintainers consulting either remaining source will receive the opposite toolchain constraint, so update both while recording this new learned fact.

AGENTS.md reference: AGENTS.md:L3-L3

Useful? React with 👍 / 👎.

- **No `std`.** The `std` feature reaches `getrandom 0.2`, which refuses to
compile for `wasm32-unknown-unknown`. `no_std` leaves the allocator and panic
handler to the adapter, which is why it carries `dlmalloc` and a trapping
Expand Down
4 changes: 2 additions & 2 deletions wasm/evm2/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion wasm/evm2/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ crate-type = ["cdylib", "rlib"]
[dependencies]
# evm2 is resolved from Cargo's external git cache at an exact revision. Its
# source never enters this repository or the npm package.
evm2 = { git = "https://github.com/alloy-rs/evm2", rev = "c49e4aa3c84733702d0ce0397d7e90c21b46ae8d", default-features = false, features = [
evm2 = { git = "https://github.com/alloy-rs/evm2", rev = "8ff36b5359aa1ccc5bdd7eb1c98d0a7f3daac469", default-features = false, features = [
"map-foldhash",
"parse",
] }
Expand Down
4 changes: 2 additions & 2 deletions wasm/evm2/NOTICE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

The artifact is compiled from `wasm/evm2` against
[`alloy-rs/evm2`](https://github.com/alloy-rs/evm2) at commit
`c49e4aa3c84733702d0ce0397d7e90c21b46ae8d`, which is licensed under MIT OR Apache-2.0. Its license texts are
`8ff36b5359aa1ccc5bdd7eb1c98d0a7f3daac469`, which is licensed under MIT OR Apache-2.0. Its license texts are
committed beside this file as `LICENSE-MIT` and `LICENSE-APACHE`.

Everything compiled into the artifact is listed below, with the license each
Expand Down Expand Up @@ -64,7 +64,7 @@ crate declares.
| `either` | 1.17.0 | MIT OR Apache-2.0 | crates.io |
| `elliptic-curve` | 0.13.8 | Apache-2.0 OR MIT | crates.io |
| `elliptic-curve` | 0.14.1 | Apache-2.0 OR MIT | crates.io |
| `evm2` | 0.1.0 | MIT OR Apache-2.0 | https://github.com/alloy-rs/evm2 @ c49e4aa3c84733702d0ce0397d7e90c21b46ae8d |
| `evm2` | 0.1.0 | MIT OR Apache-2.0 | https://github.com/alloy-rs/evm2 @ 8ff36b5359aa1ccc5bdd7eb1c98d0a7f3daac469 |
| `ff` | 0.13.1 | MIT/Apache-2.0 | crates.io |
| `ff` | 0.14.0 | MIT/Apache-2.0 | crates.io |
| `foldhash` | 0.2.0 | Zlib | crates.io |
Expand Down
Loading