test(evm): complete the coverage classification and differential budget - #381
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5ae6f34423
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| #[test] | ||
| fn match_what_the_binding_publishes() { | ||
| // Update `src/evm/System.ts` when one of these fails. | ||
| assert_eq!(address(SYSTEM_ADDRESS), "0xfffffffffffffffffffffffffffffffffffffffe"); |
There was a problem hiding this comment.
When an evm2 upgrade changes one of these constants, this test can be made green by updating only the duplicated Rust literal while leaving src/evm/System.ts stale; accidental edits to the TypeScript exports are likewise invisible. The test never reads the binding it claims to check, so record the upstream values in a shared/generated fixture and assert the System exports against that fixture to enforce the required evm2 mapping.
AGENTS.md reference: AGENTS.md:L49-L49
Useful? React with 👍 / 👎.
commit: |
1 participant
Raises the generated differential corpus to 512 cases and pins the system addresses the binding publishes as literals against evm2's own, so an upstream change fails rather than shipping a wrong address.
Completes O9's coverage classification: no unwrapped capability remains now that the block-state surface has landed.