compression rebound speed histogram#155
Merged
wfelliss merged 5 commits intoMay 16, 2026
Merged
Conversation
Made lineHistogram base component. Made velocityHistogram (using speed util and lineHistogram component) Cleaned up chart sections for consistency (Language: Displacement->travel, Fork/Shock->Suspension)
4 tasks
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new LineHistogram base component and a VelocityHistogram domain component to visualize suspension velocity data. It also refactors existing chart sections for better naming consistency and integrates the new velocity plots. Key feedback includes fixing an undefined type in VelocityHistogram, removing a misleading comment and an unused import, and addressing a performance bottleneck in LineHistogram where the entire D3 chart re-renders on hover. Additionally, a hardcoded frequency value in VelocityHistogram was flagged as a potential source of calculation errors.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Fixes from code review
…ttps://github.com/wfelliss/SDSD into 129-feature-add-compression-vs-rebound-speed-chart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made$\rightarrow$ $\rightarrow$
lineHistogrambase component (Very similar tohistogrambut it draws a line through the midpoints of the bin counts)Made
velocityHistogram(UsesbuildVelocitySamplesutil to populatelineHistogramcomponent)Cleaned up chart sections for consistency (Language:
DisplacementTravel,Fork/ShockSuspension)