Conversation
…ssCompressions function cleaner
import app/hooks/useRunMetrics.ts Not part of the trims commit, but its good to fix this here for DRY principles.
Feat/reb comp
Made lineHistogram base component. Made velocityHistogram (using speed util and lineHistogram component) Cleaned up chart sections for consistency (Language: Displacement->travel, Fork/Shock->Suspension)
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Fixes from code review
…ttps://github.com/wfelliss/SDSD into 129-feature-add-compression-vs-rebound-speed-chart
…rebound-speed-chart compression rebound speed histogram
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements a run trimming feature, enabling users to set inclusive sample bounds for telemetry data. Key changes include backend validation for trim indices, database schema updates, and several new visualization components such as ScatterPlot and ReboundCompressionPlot. The frontend now supports interactive trimming via a new popup and synchronized brushing across plots. Review feedback identified a high-severity fencepost error in the index scaling logic and recommended performance optimizations in the LinePlot component to prevent redundant re-renders.
…t-change-mouse-type-to-click feat: add cursor-pointer thoughtout where it is nessasarry
feat: add recommendations section to inform the user of the tooltips
…factor refactor: move summary section to the top
rngf4
approved these changes
May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v0.5.0