Creates a fixed navbar for the land page with the bootstrap vars#2172
Open
yontank wants to merge 1 commit intowger-project:masterfrom
Open
Creates a fixed navbar for the land page with the bootstrap vars#2172yontank wants to merge 1 commit intowger-project:masterfrom
yontank wants to merge 1 commit intowger-project:masterfrom
Conversation
Fix: Navbar should remain visible when scrolling Fixes wger-project#2078
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check that the PR fulfills these requirements
ruff format && isort .)Other questions
(e.g. database migration, deployment changes)?
Proposed Changes
There was an issue that asked for a scroll-able nav on landpage, I found that feature a pretty good idea and tried to implement it.
The only thing I'm wondering about is, if the use of
stylecss feature is allowed since I didn't see a CSS file connected to the template.Fix: Navbar should remain visible when scrolling
Fixes #2078