Fix(manager) : Make weight and rep units mandatory #2203#2275
Open
pankaj-basnet wants to merge 5 commits intowger-project:masterfrom
Open
Fix(manager) : Make weight and rep units mandatory #2203#2275pankaj-basnet wants to merge 5 commits intowger-project:masterfrom
pankaj-basnet wants to merge 5 commits intowger-project:masterfrom
Conversation
…ry and WorkoutLog This migration ensures that legacy workout data is compatible with new unit-aware calculation logic. It defaults missing units to ID 1 (KG/Repetitions)
…nd WorkoutLog tables) - data migration to backfill null units with defaults already done. - Update SlotEntry and WorkoutLog models to non-nullable ForeignKeys.
…titions_units_non_nullable.py
…n units in SlotEntry and Log tables wger-project#2203 Enforce mandatory units in Log and SlotEntry models
…del clean() for mandatory units
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
managerapp. By removing nullability from these fields, we simplify the client-side logic (Flutter/React) and ensure consistent data integrity across the platform.weight_unitandrepetition_unitnon-nullable inSlotEntryandWorkoutLog.Proposed Changes
NULLunits to default values (ID 1).NOT NULLconstraints.Related Issue(s)
Fixes #2203.
NOTE: Todo tasks for react/flutter remaining.